fix(api): public profile private state, longer JWT expiry, hermetic tests, and xdist acceleration (#296, #300, #284, #285) - #311
Merged
Conversation
web#180 (unreleased movies show a release date instead of a rank affordance) was applied to the watchlist card but not search results, because search only ever returned a truncated year. Threads TMDB's release_date through search-hit normalization so the web client can tell an unreleased title apart there too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #296, #300, #284, and #285 in
druthers-api.Fix 404 error on public profile when all user domains are private (Fix 404 error on public profile when all user domains are private #296):
visibility_profileadmits the viewer but all domain permissions are private,/v1/public/{handle}now returns HTTP 200 withshelves: []and profile header metadata instead of 404 Not Found.?shelf=category) continues to return 404 Not Found.Increase JWT access token expiry beyond 15 minutes (Increase JWT access token expiry beyond 15 minutes #300):
access_token_expire_minutesto 1440 minutes (24 hours) inapp/config.py.create_access_token()inapp/auth/oauth2.pyandauthentication.pyto dynamically usesettings.access_token_expire_minutes.Stop integration tests calling live upstream providers (Stop integration tests calling live upstream providers #284):
tests/conftest.pythat fails any test attempting outbound non-loopback HTTP connections, naming the offending host.conftest.pyfor TMDB, TVMaze, Open Library, IGDB, and watch provider search/enrichment during integration tests.Speed up test suite: cheap Argon2 in tests, add xdist (Speed up the test suite: cheap Argon2 in tests, add xdist #285):
time_cost=1, memory_cost=8, parallelism=1) whenENV=testinapp/config.pyandapp/db/hash.py.argon2_config_test.pyverifying that production settings (ENV=prod/ENV=local) retain strong Argon2 cost defaults.pytest-xdist==3.6.1torequirements/test.txtand-n autotopytest.ini.Test Performance Wall-Clock Benchmark (#285)
Closes #296. Closes #300. Closes #284. Closes #285.