fix: make Forecaster runtime device-safe - #246
Open
gyx09212214-prog wants to merge 1 commit into
Open
Conversation
gyx09212214-prog
force-pushed
the
codex/forecaster-runtime-guards
branch
from
June 15, 2026 13:33
7705882 to
dc0627a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
float16only when CUDA is available and default tofloat32on CPU-only runtimesFINGPT_TORCH_DTYPEoverride support with explicit validation, plus unit coverage for dtype resolution, NVML handling, and CUDA cache cleanupWhy this matters
The Forecaster demo currently assumes CUDA fp16/NVML availability. That can break local CPU-only or Windows smoke tests before users reach the actual forecasting flow. Keeping runtime hardware checks best-effort, while failing fast on invalid explicit dtype overrides, makes the demo easier to validate without changing the model path for CUDA users.
Scope
This addresses the NVML and CPU fp16 runtime failure patterns reported in #119 without changing model loading, prompts, market data access, or generated forecasting behavior.
Validation
python -m pytest fingpt\FinGPT_Forecaster\tests\test_runtime_utils.py -q- 8 passedgit diff --check- clean