Skip to content

Continuous enhancement: visible quality summary details - #235

Open
ryun6249 wants to merge 18 commits into
AI4Finance-Foundation:masterfrom
ryun6249:automation/continuous-enhancement-20260519-0502
Open

Continuous enhancement: visible quality summary details#235
ryun6249 wants to merge 18 commits into
AI4Finance-Foundation:masterfrom
ryun6249:automation/continuous-enhancement-20260519-0502

Conversation

@ryun6249

Copy link
Copy Markdown

Continuous Enhancement Report

1. Current Status

  • Project purpose: Local FinGPT research workstation for market, macro, quant, portfolio, and AI-assisted briefing workflows.
  • Existing structure preserved: Yes. Static FastAPI-served UI, dashboard tabs, global range selector, and Quantamental AI guardrails were preserved.
  • Main issues found: The top-right quality badge had observation count, missing-data state, and AI snapshot time only in tooltip/detail context, so the always-visible summary did not fully satisfy the quality-area requirement.

2. Changes Made

Compatibility

  • Preserved existing API contracts, dashboard filters, click-through quality panel behavior, and global range state.

Data Consistency

  • Normalized visible quality values for observation count, missing-data state, and AI snapshot time without changing upstream payload shapes.

UI/UX

  • Added always-visible 관측치, 결측, and AI 기준 fields to the top-right quality summary.
  • Added Korean aria-label content covering all seven summary fields.
  • Adjusted wrapping so the badge remains usable on desktop and 390px mobile.

Visualization

  • No chart logic changed. This pass focused on the global quality context shown above chart/table/AI surfaces.

AI Briefing

  • Kept existing Quantamental used-data guardrails intact and re-ran AI briefing regression tests.

Translation

  • Preserved Korean labels and avoided translating tickers, numbers, dates, or units.

Performance

  • Added only lightweight formatting helpers; no polling or additional fetch loop was introduced.

Tests / Validation

  • Static JS, UI contract, UI routing/module tests, Quantamental AI guard tests, and Playwright desktop/mobile checks passed.

3. Changed Files

File Change Reason
app/web/index.html Added visible quality summary placeholders and Korean aria label Ensure all required quality fields exist before runtime data loads
app/web/app.js Added compact display helpers and rendered observation/missing/AI fields Make quality status meaningful without opening diagnostics
app/web/styles.css Added wrapping/responsive rules for the expanded quality badge Prevent topbar overflow and mobile clipping
scripts/check_ui_contract.py Required the new quality summary markers Prevent regression in static contract checks
tests/test_ui_routing_contract.py Asserted new markers/helpers Keep UI routing contract aligned with the expanded badge
docs/CONTINUOUS_ENHANCEMENT_LOG.md Recorded current analysis, scope, and validation Preserve automation audit trail

4. Validation Results

Check Command / Tool Result Notes
Lint git diff --check -- app/web/index.html app/web/app.js app/web/styles.css tests/test_ui_routing_contract.py scripts/check_ui_contract.py docs/CONTINUOUS_ENHANCEMENT_LOG.md Passed No whitespace errors in touched files
Build node --check app/web/app.js Passed Repo has no frontend package manifest; static JS syntax used as build proxy
Test python -m pytest tests/test_ui_routing_contract.py -q Passed 39 passed, 4 subtests passed
Test python -m pytest tests/test_ui_modules.py -q Passed 2 passed
Test python -m pytest tests/test_quantamental_api.py -q Passed 20 passed; AI used-data guard contract preserved
UI validation playwright-cli at http://127.0.0.1:8352/ui/?range=1Y#quantamental Passed Desktop snapshot exposed all seven fields
UI validation playwright-cli resize 390 900 + DOM check Passed horizontalOverflow=false, panelView=all
Data validation UI contract + live DOM Passed Selected period and quality summary fields remain visible
AI briefing validation python -m pytest tests/test_quantamental_api.py -q Passed No unsupported AI value invention regression detected

5. Remaining Risks

  • The repository already had many unrelated dirty and untracked files before this run; this PR only stages the six files listed above.
  • Previous PR Continuous enhancement: UI, data quality, visualization, and validation #234 is still open, so this branch is stacked on its prior continuous-enhancement commit until that work is merged.
  • Full pytest was not run in this pass to stay within the automation runtime and avoid unrelated dirty-worktree noise.

6. Next Enhancement Suggestions

  1. Add a small inline quality-detail popover that mirrors the badge fields without forcing the full diagnostics panel.
  2. Add a per-tab range-support indicator for controls that cap or approximate global ranges.
  3. Extend live browser smoke to assert quality badge content after a successful Quantamental analysis response.

7. Safety Notes

  • main/master was not modified directly.
  • Auto-merge was not enabled.
  • Secrets were not touched.
  • Trading/order execution logic was not modified.
  • Unsupported facts were not presented as verified.

Your Name added 18 commits May 15, 2026 01:04
Add browser-based validation gate, decision-grade research pipeline, web UI, tests, and docs.

Archive legacy FinGPT and finogrid sources under legacy/archive while keeping runtime artifacts ignored.
Adds the FinGPT-native Quant Lab router split, artifact-backed workflows, replay/freshness controls, strategy governance, export verification/history, offline package verification, and guarded cross-run cleanup documentation and tests.

Verified before commit: python -m pytest tests -q (367 passed, 3 subtests passed), node --check app\\web\\app.js, python scripts\\check_ui_contract.py, python -m core.preflight, scripts\\verify_production_path.ps1, and quant_lab_ui_smoke.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant