Repository navigation
fix(auth): show the generic message when getSession fails - #542
Draft
9thLevelSoftware wants to merge 1 commit into
Draft
9thLevelSoftware wants to merge 1 commit into
9thLevelSoftware wants to merge 1 commit into
Conversation
AuthCallback rendered the raw Supabase session error. Keep that detail in the console and show GENERIC_AUTH_FAILURE_MESSAGE instead. Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
phoenix-portal | e17aa9d | Commit Preview URL Branch Preview URL |
Oct 25 2026, 08:17 AM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
supabase.auth.getSession()returned an error during OAuth callback exchange,AuthCallbackrenderederror.messageon the failure card. That path now logs the raw error withconsole.errorand shows the existingGENERIC_AUTH_FAILURE_MESSAGE("Authentication could not be completed. Please try again."). Successful session resolution and the URL error-code mapping are unchanged.Verification
npm test -- src/app/components/__tests__/AuthCallback.test.tsx: 9 passed, including a new case that agetSessionerror shows the generic copy and does not render the provider message.npm run lint: exit 0 (255 pre-existing warnings, no new diagnostics in the changed files).npm run typecheck: OK — no new type errors (app 21 known, test 139 known).