Repository navigation
fix(onboarding): use string keys for dismissed_hints record schema - #541
Draft
9thLevelSoftware wants to merge 1 commit into
Draft
9thLevelSoftware wants to merge 1 commit into
9thLevelSoftware wants to merge 1 commit into
Conversation
Zod 4's one-argument z.record treats the argument as the key schema, so string hint ids failed to parse after the first dismiss. Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
phoenix-portal | 980398e | Commit Preview URL Branch Preview URL |
Oct 24 2026, 08:32 AM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dismissed_hintsused Zod 4's one-argumentz.record(z.boolean()), which treats the argument as the key schema. After the first hint dismiss (recovery-readinessand any other string id),onboardingSchema.parsein the onboarding query failed, so feature hints and the What's New check stopped loading.typecheck-baseline.jsonwas hiding the mismatch as TS2554.dismissed_hintsis nowz.record(z.string(), z.boolean()).default({}).{ "recovery-readiness": true }on a full onboarding row.src/schemas/onboarding.tsTS2554 entries were removed from the app and test baselines by hand.Verification
npm run typecheck: app 20 errors (was 21), test 138 errors (was 139), 0 new.npm run lint: 255 warnings, exit 0 (no new warnings).npm test: 2487 passed, 16 skipped, 0 failed (includes the new schema test).