Repository navigation
fix(tvos): validate and normalize exported IPA filename - #1354
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 4ed66e9)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4ed66e9)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (2 files)
Reviewed by minimax-m3 · Input: 98.4K · Output: 49.1K · Cached: 1.1M Review guidance: REVIEW.md from base branch |
|
Independent release-tooling review accepted at |
|
Independent tvOS release attestation accepted for merge SHA Authorized operation remains experimental TV_OS1.0.8 TestFlight only, preserving existing tester groups and phone signing. This is a recovery of failed export run40392894434, whose signed archive succeeded but upload was skipped. No physical Apple TV/Vitruvian or live cloud roundtrip proof, no certified emergency-stop claim, and no unrelated App Store/full-release approval. The pre-existing nonblocking iOS-native failures remain explicitly unverified/unfixed. Uploaded build processing and actual tester availability still require Apple readback. |
Release blocker correction for #1288
TV-only release run 40392894434 passed real simulator tests, signed archive, codesign and embedded TV-profile verification. Xcode export returned 0, but a hardcoded
PhoenixTV.ipalookup failed; upload was skipped. The exported name itself was not retained and is not claimed observed.Discover exactly one root IPA, validate embedded bundle/platform/marketing/build metadata, then normalize its filename for the unchanged uploader. Missing/ambiguous/malformed/mismatched files still fail closed. No runtime, phone, version, signing, review or upload guards changed.
Parent spec review PASS: narrow two-file scope, no credential output, ambiguity and identity rejected before rename. Parent fresh verification: tooling61/61; version helper8/8; preflight1.0.8/code12; diff-check clean, on Python3.14.7. Independent quality review and exact-head required CI remain before merge. This PR does not claim TestFlight delivery. Physical hardware remains an explicitly disclosed beta test item.