Skip to content

cleanup(ui): use all-caps label typography tokens - #1341

Merged
9thLevelSoftware merged 1 commit into
mainfrom
cursor/ui-all-caps-label-tokens-1023
Oct 23, 2026
Merged

9thLevelSoftware merged 1 commit into
mainfrom
cursor/ui-all-caps-label-tokens-1023

Conversation

@9thLevelSoftware

Copy link
Copy Markdown
Owner

Replace hand-built all-caps label styles with the shared theme tokens where size, weight, letter spacing, and casing stay the same.

Tokens in Type.kt: labelAllCaps is Typography.labelLarge (14sp, Medium, line height 20sp) with letterSpacing = 1.sp. labelSmallAllCaps is Typography.labelSmall (11sp, Medium, line height 16sp) with letterSpacing = 1.sp. Neither token changes text case.

Replaced

  • EchoLevelPillSelector.kt — Echo level heading. Was labelSmall plus letterSpacing = 1.sp (weight stays Medium, no case transform). Now labelSmallAllCaps.
  • EquipmentRackSelectionCard.kt — rack heading. Was labelLarge plus FontWeight.Bold plus letterSpacing = 1.sp (no case transform; the string stays title case). Now labelAllCaps.copy(fontWeight = FontWeight.Bold).
  • RestTimerCard.kt — “NEXT SET CONFIGURATION”. Was labelLarge plus FontWeight.Bold plus letterSpacing = 1.sp (no case transform). Now labelAllCaps.copy(fontWeight = FontWeight.Bold).

Left as-is

  • RestTimerCard.kt rest-time header: titleMedium (16sp, line height 24sp) + Bold + letterSpacing = 1.5.sp.
  • RestTimerCard.kt paused label: labelMedium (12sp) + Bold + letterSpacing = 2.sp.
  • RestTimerCard.kt “UP NEXT”: labelLarge + Bold + letterSpacing = 1.2.sp (spacing is 1.2sp, token is 1sp).

Open PRs, including #1326, do not modify these files.

Verification

./gradlew :shared:compileKotlinIosSimulatorArm64 -Pskip.supabase.check=true :shared:compileAndroidHostTest :androidApp:compileDebugKotlin — BUILD SUCCESSFUL.

Open in Web Open in Cursor 

Replace hand-built label styles that already match labelSmallAllCaps and labelAllCaps so letter spacing stays on the shared tokens.

Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
@9thLevelSoftware
9thLevelSoftware marked this pull request as ready for review October 23, 2026 14:32
Copilot AI balanced review requested due to automatic review settings October 23, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kilo-code-bot

kilo-code-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/components/EchoLevelPillSelector.kt
  • shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/components/EquipmentRackSelectionCard.kt
  • shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/screen/RestTimerCard.kt

Reviewed by minimax-m3 · Input: 57.4K · Output: 6.6K · Cached: 589.4K

Review guidance: REVIEW.md from base branch main

@9thLevelSoftware
9thLevelSoftware merged commit 4635688 into main Oct 23, 2026
11 checks passed
@9thLevelSoftware
9thLevelSoftware deleted the cursor/ui-all-caps-label-tokens-1023 branch October 23, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants