Repository navigation
cleanup(ui): use all-caps label typography tokens - #1341
Merged
Merged
Conversation
Replace hand-built label styles that already match labelSmallAllCaps and labelAllCaps so letter spacing stays on the shared tokens. Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
9thLevelSoftware
marked this pull request as ready for review
October 23, 2026 14:32
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by minimax-m3 · Input: 57.4K · Output: 6.6K · Cached: 589.4K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-built all-caps label styles with the shared theme tokens where size, weight, letter spacing, and casing stay the same.
Tokens in
Type.kt:labelAllCapsisTypography.labelLarge(14sp, Medium, line height 20sp) withletterSpacing = 1.sp.labelSmallAllCapsisTypography.labelSmall(11sp, Medium, line height 16sp) withletterSpacing = 1.sp. Neither token changes text case.Replaced
EchoLevelPillSelector.kt— Echo level heading. WaslabelSmallplusletterSpacing = 1.sp(weight stays Medium, no case transform). NowlabelSmallAllCaps.EquipmentRackSelectionCard.kt— rack heading. WaslabelLargeplusFontWeight.BoldplusletterSpacing = 1.sp(no case transform; the string stays title case). NowlabelAllCaps.copy(fontWeight = FontWeight.Bold).RestTimerCard.kt— “NEXT SET CONFIGURATION”. WaslabelLargeplusFontWeight.BoldplusletterSpacing = 1.sp(no case transform). NowlabelAllCaps.copy(fontWeight = FontWeight.Bold).Left as-is
RestTimerCard.ktrest-time header:titleMedium(16sp, line height 24sp) + Bold +letterSpacing = 1.5.sp.RestTimerCard.ktpaused label:labelMedium(12sp) + Bold +letterSpacing = 2.sp.RestTimerCard.kt“UP NEXT”:labelLarge+ Bold +letterSpacing = 1.2.sp(spacing is 1.2sp, token is 1sp).Open PRs, including #1326, do not modify these files.
Verification
./gradlew :shared:compileKotlinIosSimulatorArm64 -Pskip.supabase.check=true :shared:compileAndroidHostTest :androidApp:compileDebugKotlin— BUILD SUCCESSFUL.