Repository navigation
cleanup(ios): correct HealthIntegration.isAvailable KDoc - #1339
Merged
9thLevelSoftware merged 1 commit intoOct 23, 2026
Merged
Conversation
isAvailable() only calls HKHealthStore.isHealthDataAvailable and returns false when that check throws. It does not inspect a HealthKit restricted state. Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
9thLevelSoftware
marked this pull request as ready for review
October 23, 2026 14:32
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge VerdictApprove — KDoc-only correction; the new wording accurately describes what Correctness / Safety FindingsNo correctness or safety findings. Ponytail ReviewPonytail: Lean already. Ship. Ponytail net: 0 lines. Suggested Minimal PatchNo patch needed. Final Merge GuidanceCan merge as-is. No build was re-run during review (read-only session); the diff touches only KDoc text, so there is no compile-surface change. Files Reviewed (1 file)
Reviewed by minimax-m3 · Input: 43.5K · Output: 7K · Cached: 383.7K Review guidance: REVIEW.md from base branch |
9thLevelSoftware
deleted the
cursor/ios-health-availability-kdoc-restricted-1023
branch
October 23, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the KDoc on
HealthIntegration.isAvailable()inshared/src/iosMain/kotlin/com/devil/phoenixproject/data/integration/HealthIntegration.ios.kt.The function only calls
HKHealthStore.isHealthDataAvailable()and returns false if that check throws. The previous comment also said a restricted device returns false, which this function does not check.Verification:
./gradlew :shared:compileKotlinIosSimulatorArm64 -Pskip.supabase.check=true :shared:compileAndroidHostTest :androidApp:compileDebugKotlin(BUILD SUCCESSFUL).