Skip to content

cleanup(skills): drop duplicated version literals from update-phoenix-version - #1337

Merged
9thLevelSoftware merged 2 commits into
mainfrom
cursor/version-skill-stale-checked-in-defaults-1023
Oct 23, 2026
Merged

9thLevelSoftware merged 2 commits into
mainfrom
cursor/version-skill-stale-checked-in-defaults-1023

Conversation

@9thLevelSoftware

@9thLevelSoftware 9thLevelSoftware commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

The update-phoenix-version helper's help text and agent prompt each repeated the checked-in versionName / versionCode. The 1.0.7 release (0d3729b) updated SKILL.md but not those copies, so they still said 1.0.6 / 10. They now point at androidApp/build.gradle.kts and no longer restate the values. That removes the copies that drift rather than syncing them for one release. Help strings only: argparse defaults and script logic are unchanged. SKILL.md is unchanged; its live-default notes are part of the release bump.

Files:

  • .agents/skills/update-phoenix-version/agents/openai.yaml: the prompt reads the current versionName and default versionCode "from androidApp/build.gradle.kts".
  • .agents/skills/update-phoenix-version/scripts/update_version.py: --version and --android-code help name the source file, or "the checked-in default", instead of a value.

Verification:

  • python3 .agents/skills/update-phoenix-version/scripts/update_version.py --help prints the new help.
  • python3 .agents/skills/update-phoenix-version/scripts/update_version.py --check --version 1.0.7 --android-code 11 reports metadata aligned.
  • openai.yaml parses.
  • There are no existing tests for this script.

Align the skill prompt and argparse help examples with the checked-in 1.0.7 / versionCode 11, and include the skill directory in the stale-literal search roots.

Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
@9thLevelSoftware
9thLevelSoftware marked this pull request as ready for review October 23, 2026 14:32
Copilot AI balanced review requested due to automatic review settings October 23, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kilo-code-bot

kilo-code-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • .agents/skills/update-phoenix-version/agents/openai.yaml
  • .agents/skills/update-phoenix-version/scripts/update_version.py

Verdict

Approve — the previous WARNING and both SUGGESTIONs are fixed in 0ca2c2ed: the skill-directory search root is gone from the step-5 rg command (net-zero vs base), and the duplicated version literals are deleted from the argparse help and the agent prompt, which now point at androidApp/build.gradle.kts.

Correctness / Safety Findings

No correctness or safety findings.

Verified against current HEAD 0ca2c2ed:

  • scripts/update_version.py L48 / L56: help strings only — parse_args, validate_args, and all target/pattern logic are unchanged, so --check / --dry-run behavior is unaffected.
  • agents/openai.yaml L4: the prompt still names every surface it must keep aligned (Constants.APP_VERSION, both iOS MARKETING_VERSION values) and no longer restates a version value.
  • Single source of truth confirmed: androidApp/build.gradle.kts L190 versionCode = injectedVersionCode ?: 11 and L191 versionName = "1.0.7", with shared/.../Constants.kt L8 and project.pbxproj L345/L381 all on 1.0.7. A repo-wide grep for checked-in 1.0.7 / checked-in 11 / Checked-in default is returns 0 matches, so the drift class this PR targets is closed.

Ponytail Review

Ponytail: Lean already. Ship.

Suggested Minimal Patch

No patch needed.

Final Merge Guidance

Can merge as-is — the PR is already merged at 0ca2c2ed; no follow-up required.

Previous Review Summary (commit 2cd77cd)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 2cd77cd)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 2
Issue Details (click to expand)

WARNING

File Line Issue
.agents/skills/update-phoenix-version/SKILL.md 64 Step-5 search now scans the skill's own directory: it matches structural lines that must not be edited (SKILL.md L16-L19, L24, and the rg command at L64 itself) while no rule (L67) says which skill-owned literals to update, and it misses the versionCode literal at update_version.py L56 that will drift again. Add an explicit rule at L67, or drop the added root.

SUGGESTION

File Line Issue
.agents/skills/update-phoenix-version/scripts/update_version.py 48 Hand-synced "(checked-in 1.0.7)" duplicates androidApp/build.gradle.kts L191 and already drifted once (release commit 0d3729b updated only SKILL.md, leaving this text and openai.yaml on 1.0.6/10). Delete the literal; same for L56.
.agents/skills/update-phoenix-version/agents/openai.yaml 4 Hand-synced "(checked-in 1.0.7)"/"(checked-in 11)" in the agent prompt drifted on the 1.0.7 release; this PR is a manual one-release fix. Delete the parentheticals.
Files Reviewed (3 files)
  • .agents/skills/update-phoenix-version/SKILL.md - 1 issue
  • .agents/skills/update-phoenix-version/agents/openai.yaml - 1 issue
  • .agents/skills/update-phoenix-version/scripts/update_version.py - 1 issue

Verdict

Comment only — the version sync itself is correct (verified: androidApp/build.gradle.kts L190-191 versionCode 11 / versionName "1.0.7", Constants.kt L8 APP_VERSION = "1.0.7", project.pbxproj L345 and L381 MARKETING_VERSION = 1.0.7; no stale 1.0.6 remains except the historical note in CLAUDE.md L119), but the added search root needs one clarifying rule.

Correctness / Safety Findings

  • important: .agents/skills/update-phoenix-version/SKILL.md:L64: step 5 now scans the skill's own files. The scan matches structural documentation (SKILL.md L16-L19 "Version Surfaces", L24, and the rg command on L64) and the instruction at L67 gives no rule separating "must update" literals from "must not touch" lines, so a release-bump run can corrupt the skill's own instructions (e.g. unescaping the 1\.0\.7 pattern into 1.0.7, which matches 1x0x7). The scan also has no term matching the versionCode literal, so update_version.py L56 ("Checked-in default is 11") is invisible and will rot exactly like the version literal did. Fix: name the skill-owned literals to update and the structural lines to leave alone at L67, or revert the added root.
  • minor: PR description says "Help strings only", but the SKILL.md L64 change alters the skill's step-5 search scope, i.e. it is a workflow change, not help text. Note this in the description so reviewers re-check it.

Ponytail Review

  • .agents/skills/update-phoenix-version/scripts/update_version.py:L48: delete: hand-synced "(checked-in 1.0.7)" duplicate of androidApp/build.gradle.kts L191. Read the value from the build file instead; there is then nothing to keep in sync.
  • .agents/skills/update-phoenix-version/scripts/update_version.py:L56: delete: "Checked-in default is 11" duplicate of androidApp/build.gradle.kts L190. Same fix as L48.
  • .agents/skills/update-phoenix-version/agents/openai.yaml:L4: delete: hardcoded "(checked-in 1.0.7)"/"(checked-in 11)" in the agent prompt. The prompt already says to read the current versionName; drop the parentheticals.
  • .agents/skills/update-phoenix-version/SKILL.md:L64: shrink: the added root makes the skill search itself. Optional — if the duplicated literals above are deleted, this root becomes unnecessary.

Ponytail net: -3 lines.

Suggested Minimal Patch

Same three files, no new dependencies, no behavior change to update_version.py:

  1. scripts/update_version.py: drop "(checked-in 1.0.7)" from the --version help and merge the --android-code help into one string without the literal 11.
  2. agents/openai.yaml: drop "(checked-in 1.0.7)" and "(checked-in 11)".
  3. SKILL.md: either revert L64 to the previous roots (drop the self-scan) or keep it and add one sentence at L67 listing the skill-owned literals to update and stating that the "Version Surfaces" list and the L64 command must not be edited.

Final Merge Guidance

Can merge; the WARNING is a one-sentence fix in SKILL.md and the Ponytail deletions are optional cleanup that also removes the recurring hand-sync.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 42.3K · Output: 8K · Cached: 304.3K

Review guidance: REVIEW.md from base branch main

…ing them

The 1.0.7 release updated SKILL.md but not the copies of the checked-in
versionName/versionCode in update_version.py's help text and the agent
prompt, which is why they had drifted. Remove those copies so both point at
androidApp/build.gradle.kts, and drop the extra search root: SKILL.md's
live-default notes are already updated by the release, and searching the
skill's own directory matched its structural lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015tsDJ6LzV6FwGD3VQwfNEn
@9thLevelSoftware 9thLevelSoftware changed the title cleanup(skills): sync update-phoenix-version example versions cleanup(skills): drop duplicated version literals from update-phoenix-version Oct 23, 2026
@9thLevelSoftware
9thLevelSoftware merged commit 96f19d8 into main Oct 23, 2026
11 checks passed
@9thLevelSoftware
9thLevelSoftware deleted the cursor/version-skill-stale-checked-in-defaults-1023 branch October 23, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants