Repository navigation
cleanup(skills): drop duplicated version literals from update-phoenix-version - #1337
Conversation
Align the skill prompt and argparse help examples with the checked-in 1.0.7 / versionCode 11, and include the skill directory in the stale-literal search roots. Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
VerdictApprove — the previous WARNING and both SUGGESTIONs are fixed in Correctness / Safety FindingsNo correctness or safety findings. Verified against current HEAD
Ponytail ReviewPonytail: Lean already. Ship. Suggested Minimal PatchNo patch needed. Final Merge GuidanceCan merge as-is — the PR is already merged at Previous Review Summary (commit 2cd77cd)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2cd77cd)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
VerdictComment only — the version sync itself is correct (verified: Correctness / Safety Findings
Ponytail Review
Ponytail net: -3 lines. Suggested Minimal PatchSame three files, no new dependencies, no behavior change to
Final Merge GuidanceCan merge; the WARNING is a one-sentence fix in Reviewed by minimax-m3 · Input: 42.3K · Output: 8K · Cached: 304.3K Review guidance: REVIEW.md from base branch |
…ing them The 1.0.7 release updated SKILL.md but not the copies of the checked-in versionName/versionCode in update_version.py's help text and the agent prompt, which is why they had drifted. Remove those copies so both point at androidApp/build.gradle.kts, and drop the extra search root: SKILL.md's live-default notes are already updated by the release, and searching the skill's own directory matched its structural lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015tsDJ6LzV6FwGD3VQwfNEn
The update-phoenix-version helper's help text and agent prompt each repeated the checked-in
versionName/versionCode. The 1.0.7 release (0d3729b) updatedSKILL.mdbut not those copies, so they still said 1.0.6 / 10. They now point atandroidApp/build.gradle.ktsand no longer restate the values. That removes the copies that drift rather than syncing them for one release. Help strings only: argparse defaults and script logic are unchanged.SKILL.mdis unchanged; its live-default notes are part of the release bump.Files:
.agents/skills/update-phoenix-version/agents/openai.yaml: the prompt reads the current versionName and default versionCode "from androidApp/build.gradle.kts"..agents/skills/update-phoenix-version/scripts/update_version.py:--versionand--android-codehelp name the source file, or "the checked-in default", instead of a value.Verification:
python3 .agents/skills/update-phoenix-version/scripts/update_version.py --helpprints the new help.python3 .agents/skills/update-phoenix-version/scripts/update_version.py --check --version 1.0.7 --android-code 11reports metadata aligned.openai.yamlparses.