Skip to content

cleanup(build): correct androidMain dependency comments - #1336

Merged
9thLevelSoftware merged 1 commit into
mainfrom
cursor/gradle-androidmain-dependency-comments-1023
Oct 23, 2026
Merged

9thLevelSoftware merged 1 commit into
mainfrom
cursor/gradle-androidmain-dependency-comments-1023

Conversation

@9thLevelSoftware

Copy link
Copy Markdown
Owner

Updates only the androidMain dependency comments in shared/build.gradle.kts.

Activity Compose also covers BackHandler and the file-picker, directory-picker, BLE, and Health Connect activity-result launchers. DocumentFile also covers SAF tree create/delete and CreateDocument cleanup.

Verification: ./gradlew :shared:compileKotlinIosSimulatorArm64 -Pskip.supabase.check=true :shared:compileAndroidHostTest :androidApp:compileDebugKotlin (BUILD SUCCESSFUL).

Open in Web Open in Cursor 

Activity Compose also backs BackHandler and the BLE, Health Connect, and directory-picker activity-result launchers. DocumentFile also backs SAF tree create/delete and CreateDocument cleanup.

Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
@9thLevelSoftware
9thLevelSoftware marked this pull request as ready for review October 23, 2026 14:31
Copilot AI balanced review requested due to automatic review settings October 23, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kilo-code-bot

kilo-code-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • shared/build.gradle.kts - 0 issues
Verification Notes

Comment-only change (no dependency or source changes). Every claim in the new comments was checked against the source:

  • androidx.activity.compose → androidx.activity:activity-compose backs BackHandler (shared/src/androidMain/kotlin/com/devil/phoenixproject/presentation/components/BackHandler.android.kt:10), the file-picker launchers (util/FilePicker.android.kt:43, :67), the directory picker (util/BackupLocationPicker.android.kt:29), BLE permissions (presentation/components/BlePermissionHandler.android.kt:116), and Health Connect (util/HealthPermissionRequester.android.kt:19).
  • androidx.documentfile → androidx.documentfile:documentfile backs directory-picker display names (util/BackupLocationPicker.android.kt:40), SAF tree create/delete (util/BackupDestinationResolver.android.kt:65, :71, :82), and CreateDocument cleanup (util/FilePicker.android.kt:115).

Both old comments were incomplete; both new ones are accurate. Gradle build verification was not re-run (read-only review); comment-only edits cannot affect compilation.

Ponytail Review

Ponytail: Lean already. Ship.

Ponytail net: 0 lines.

Final Merge Guidance

Can merge as-is.


Reviewed by minimax-m3 · Input: 33.1K · Output: 5.3K · Cached: 257.4K

Review guidance: REVIEW.md from base branch main

@9thLevelSoftware
9thLevelSoftware merged commit 21d3b8d into main Oct 23, 2026
11 checks passed
@9thLevelSoftware
9thLevelSoftware deleted the cursor/gradle-androidmain-dependency-comments-1023 branch October 23, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants