Repository navigation
cleanup(replay): drop unused smoothed parameter from buildRepBoundaries - #1333
Merged
Merged
Conversation
Peaks are taken from the raw positions, so the smoothed array passed into buildRepBoundaries was never read. Valley detection still uses the smoothed series. Co-authored-by: Devil <9thLevelSoftware@users.noreply.github.com>
9thLevelSoftware
marked this pull request as ready for review
October 23, 2026 14:31
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by minimax-m3 · Input: 34.5K · Output: 5.9K · Cached: 339.1K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildRepBoundariesaccepted asmoothedarray it never read. Peaks still come from the raw positions, and valley detection still uses the smoothed series, so that computation stays.Verified with
:shared:compileKotlinIosSimulatorArm64,:shared:compileAndroidHostTest,:androidApp:compileDebugKotlin, andRepBoundaryDetectorTest(13 tests, 0 failures).