[9thLevelSoftware]

Summary

• MetricPollingEngine's class KDoc now matches the loops in code. The monitor poll has no delay on success and is rate-limited by the BLE round trip (~10-20 ms, same as startMonitorPolling). The diagnostic poll is 2 Hz / 500 ms (BleConstants.Timing.DIAGNOSTIC_POLL_INTERVAL_MS). Heuristic (4 Hz / 250 ms) and heartbeat (0.5 Hz / 2000 ms) were already correct.
• stopAll logs the workout position range through HandleStateDetector.hasObservedPositionRange(). That compares maxPositionSeen with UNSET_MAX_POSITION_MM (-Double.MAX_VALUE), the sentinel used to initialize and reset the field. Double.MIN_VALUE is the smallest positive double, so it never matched that sentinel.

Behavior

The check only decides whether stopAll emits the WORKOUT ANALYSIS info log. stopPolling and the connection manager call stopAll and do not read the result. Nothing in the UI or persistence reads minPositionSeen / maxPositionSeen; both are updated together from Float cable positions.

A finite sample moves both extremes off their sentinels, so a real workout still prints the range. A Float position cannot equal -Double.MAX_VALUE or Double.MIN_VALUE, so this does not change that log for trainer positions. The corrected guard skips the log when the maximum is still unset.

Test

HandleStateDetectorTest.position range stays unobserved until a sample leaves both sentinels covers the unset sentinels, an all-negative sample, and reset. :shared:testAndroidHostTest for HandleStateDetectorTest and MetricPollingEngineTest passed.

  

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• shared/src/commonMain/kotlin/com/devil/phoenixproject/data/ble/HandleStateDetector.kt
• shared/src/commonMain/kotlin/com/devil/phoenixproject/data/ble/MetricPollingEngine.kt
• shared/src/commonTest/kotlin/com/devil/phoenixproject/data/ble/HandleStateDetectorTest.kt

---

_{Reviewed by minimax-m3 · Input: 61.9K · Output: 9K · Cached: 523.4K}

_{Review guidance: REVIEW.md from base branch main}