[9thLevelSoftware]

Restored teardown recovery now keeps the failure reason.

markRestoredRecoveryRequired stores the TeardownFailureReason and logs transition=recovery_required through the same helper as markRecoveryRequired. beginRestoredRecoveryAttempt logs that stored value as previousReason.

WorkoutExecutionGuardRestoredRuntimeTest checks that a rejected owner leaves the stored reason in place, and that the next restored attempt still logs it.

Verified with :shared:compileKotlinIosSimulatorArm64, :shared:compileAndroidHostTest, :androidApp:compileDebugKotlin, and :shared:testAndroidHostTest --tests '*WorkoutExecutionGuardRestoredRuntimeTest*' (-Pskip.supabase.check=true). The restored-runtime suite finished with 12 tests, 0 failures.

  

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Verdict: Approve — the restored teardown path now stores and logs the failure reason through the same helpers the live path uses, and the live path's emitted log strings are byte-identical to before.

Correctness / Safety Findings

No correctness or safety findings.

Details checked: markRestoredRecoveryRequired keeps its owner/ready/state gates, so a rejected owner still cannot mutate teardown state or overwrite the stored reason; the live markRecoveryRequired / beginRecoveryAttempt log payloads and the teardownFailureReason write order are unchanged; the shared teardownFailureReason field cannot be clobbered between a restored failure and its next restored attempt because the restored record blocks beginExecutionLocked, the live path is the only writer of teardownLease, and beginTeardownLocked/markTeardownReady null the field only on the live path.

Ponytail Review

Ponytail: Lean already. Ship.

The two new private helpers each have two call sites and remove the duplicated WORKOUT_TEARDOWN format strings instead of adding an abstraction layer; the restored path reuses the existing teardownFailureReason field rather than introducing a second stored reason concept.

Ponytail net: 0 lines.

Suggested Minimal Patch

No patch needed.

Final Merge Guidance

Can merge as-is.

Files Reviewed (2 files)

• shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/manager/WorkoutExecutionGuard.kt
• shared/src/commonTest/kotlin/com/devil/phoenixproject/presentation/manager/WorkoutExecutionGuardRestoredRuntimeTest.kt

---

_{Reviewed by minimax-m3 · Input: 74.6K · Output: 24.5K · Cached: 618.4K}

_{Review guidance: REVIEW.md from base branch main}