Skip to content

feature/vote-strategy - #13

Merged
jpfrare merged 11 commits into
developfrom
feature/vote-strategy
Sep 21, 2026
Merged

feature/vote-strategy#13
jpfrare merged 11 commits into
developfrom
feature/vote-strategy

Conversation

@jpfrare

@jpfrare jpfrare commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Changes Made

  • ConclaveCountingStrategy class implemented
  • ONUCountingStrategy class implemented
  • CondominiumCountingStrategy class implemented
  • Tests for all classes and functions implemented (specification on issue Vote Strategy Implementation #5 )

How to Test

  1. Run 'npx vitest run' in /src/domain/voteStrategyTests

Related Issues

Checklist

  • Self-reviewed my code
  • Added tests that prove the fix is effective or that the feature works
  • Existing local tests pass successfully
  • Updated relevant documentation

@jpfrare jpfrare self-assigned this Sep 19, 2026
@yaesetti yaesetti linked an issue Sep 19, 2026 that may be closed by this pull request
Vote Strategy Implementation #5
Closed
yaesetti
yaesetti requested changes Sep 19, 2026
View reviewed changes
Comment thread src/domain/voteStrategyTests/onu-counting-strategy.test.ts
Comment thread src/domain/counting-strategy.ts Outdated
Comment thread src/domain/counting-strategy.ts Outdated
Comment thread src/domain/counting-strategy.ts Outdated
Comment thread src/domain/counting-strategy.ts Outdated
Comment thread src/domain/counting-strategy.ts Outdated
Comment thread src/domain/counting-strategy.ts Outdated
Comment thread src/domain/counting-strategy.ts Outdated
leonardo-ferreira-git
leonardo-ferreira-git reviewed Sep 19, 2026
View reviewed changes
Comment thread src/domain/counting-strategy.ts Outdated
@jpfrare
jpfrare merged commit d396c16 into develop Sep 21, 2026
2 checks passed
@yaesetti
yaesetti deleted the feature/vote-strategy branch September 21, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaesetti yaesetti yaesetti approved these changes
@alupcosta alupcosta alupcosta approved these changes
@leonardo-ferreira-git leonardo-ferreira-git leonardo-ferreira-git approved these changes

Assignees

@jpfrare jpfrare

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vote Strategy Implementation

4 participants

@jpfrare @yaesetti @alupcosta @leonardo-ferreira-git