Skip to content

Feature/vote class - #12

Merged
leonardo-ferreira-git merged 10 commits into
developfrom
feature/vote-class
Sep 19, 2026
Merged

leonardo-ferreira-git merged 10 commits into
developfrom
feature/vote-class

Conversation

@leonardo-ferreira-git

Copy link
Copy Markdown
Collaborator

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Changes Made

  • ConclaveVote class implemented
  • ONUVote class implemented
  • CondominiumVote class implemented
  • validateNoDuplicateVote function implemented
  • Tests for all classes and functions implemented (specification on issue Implement Vote classes and base contracts #11 )

How to Test

  1. Run npm run test or npx vitest run --reporter=verbose for showing all tests description

Related Issues

Checklist

  • Self-reviewed my code
  • Added tests that prove the fix is effective or that the feature works
  • Existing local tests pass successfully
  • Updated relevant documentation

Comment thread src/domain/Vote.test.ts Outdated
@yaesetti

Copy link
Copy Markdown
Collaborator

Code looks great, but file naming should follow kebab-case in order to ensure compatibility and standard.

Please rename files and their imports.

@yaesetti
yaesetti self-requested a review September 18, 2026 22:32
@leonardo-ferreira-git
leonardo-ferreira-git removed the request for review from jpfrare September 18, 2026 23:45

@jpfrare jpfrare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code and well implemented tests

@leonardo-ferreira-git
leonardo-ferreira-git merged commit 5508885 into develop Sep 19, 2026
1 check passed
@yaesetti yaesetti linked an issue Sep 19, 2026 that may be closed by this pull request
7 of 8 tasks
@leonardo-ferreira-git
leonardo-ferreira-git deleted the feature/vote-class branch September 19, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Vote classes and base contracts

3 participants