Skip to content

fix: reset React adapter queues on popstate - #1546

Draft
franky47 wants to merge 7 commits into
nextfrom
nightly/react-popstate-queue-leak
Draft

fix: reset React adapter queues on popstate#1546
franky47 wants to merge 7 commits into
nextfrom
nightly/react-popstate-queue-leak

Conversation

@franky47

@franky47 franky47 commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • reset pending URL update queues when the React adapter observes browser Back/Forward navigation
  • cover cancellation of a pending debounced update through the real React/Vite adapter E2E bench
  • keep the regression fixture in the regular app tree while conditionally enabling History API synchronization from React

Corrections

  • Replaced the route-specific module-scope history-sync condition with a composable React effect.
  • Removed the isolated HTML/Vite entry point and restored the regular router as the single app tree.
  • Made the regression query state non-nullable with a default value and reused the shared Display component.

@franky47 franky47 added adapters/react Uses the React SPA adapter feature/time-safety Throttle, debounce, anything related to keeping URL updates time-safe. labels Aug 12, 2026
@vercel

vercel Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nuqs Ready Ready Preview Aug 12, 2026 11:06am

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 68598a47-a5e1-478d-8409-2911770d04a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown 
pnpm add https://pkg.pr.new/nuqs@1546

commit: 53dfbcd

@franky47 franky47 added the AI slop PR generated by AI, needs some cleanup before merging label Aug 12, 2026
@franky47 franky47 added this to the 🪵 Backlog milestone Aug 12, 2026
franky47
franky47 commented Aug 12, 2026
View reviewed changes
Comment thread packages/e2e/react/src/routes/popstate-queue-reset.tsx Outdated
Comment thread packages/e2e/react/src/routes/popstate-queue-reset.tsx Outdated
Comment thread packages/e2e/react/src/routes/popstate-queue-reset.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

adapters/react Uses the React SPA adapter AI slop PR generated by AI, needs some cleanup before merging feature/time-safety Throttle, debounce, anything related to keeping URL updates time-safe.

Projects

None yet

Milestone

🪵 Backlog

Development

Successfully merging this pull request may close these issues.

1 participant

@franky47