Repository navigation
Fix autodoc support for slot writers - #69
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a2c2eda68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (if (typep writer 'list) | ||
| (second writer) | ||
| writer)) |
There was a problem hiding this comment.
When a valid slot option such as :writer (setf foo) is used without a reader, this normalization reduces the writer name to foo, so autodoc emits (foo (writer class)); GitHub source-link generation subsequently reaches locate-and-find-source in full/locatives/slots.lisp, which calls symbol-function on foo even though only (setf foo) is fbound, causing documentation rendering to signal undefined-function (or inspect an unrelated ordinary function). Preserve enough writer identity, or have writer source resolution select the matching slot writer's actual fdefinition. The new test covers only the symbol-form writer and misses this supported function-name edge case.
AGENTS.md reference: AGENTS.md:L37-L39
Useful? React with 👍 / 👎.
2 participants
Fixes #66.
Includes the original fix from @ethanxxxl without rewriting its commit, adds coverage for reader/writer/accessor classification and writer locatives, and documents the fix in the changelog.
Tests:
qlot exec sbcl --non-interactive ... (asdf:test-system "40ants-doc-test").