feat(DataGrid): Add styles to sticky columns - #125
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds visual styling to sticky columns in the DataGrid component, specifically applying borders and shadows to columns at the sticky edges to visually distinguish them from scrollable content.
Key Changes:
- Added
stickyEdgegetter logic to determine which sticky columns are at the edge of their sticky group - Applied border and shadow styles to sticky edge columns using CSS selectors
- Added comprehensive test coverage for the
stickyEdgelogic
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/DataGrid/DataGridColumn.ts | Implements stickyEdge getter to identify sticky columns at group boundaries |
| packages/DataGrid/DataGridColumnHeader.ts | Applies CSS styles and data attributes for sticky edge columns in header cells |
| packages/DataGrid/DataGridCell.ts | Applies CSS styles and data attributes for sticky edge columns in data cells |
| packages/DataGrid/DataGridColumn.test.ts | Adds unit tests covering all scenarios for the stickyEdge getter logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.