Issue 6753 - Removing ticket49303_test and porting to DSLdapObject

[aadhikar]

Description:
The old ticket49303_test.py had compatibility issues.
This ports the functionality to tls_renegotiation_test.py
using modern Encryption class from lib389.

Relates: #6753

Reviewed by: ???
Assisted by: Claude

Summary by Sourcery

Port TLS renegotiation coverage from the legacy ticket-based test to a new TLS suite test using the modern configuration interface.

Tests:

• Add a TLS renegotiation configuration test that verifies nsTLSAllowClientRenegotiation accepts on, off, and invalid values via the Encryption API.
• Remove the obsolete ticket49303 TLS renegotiation test module.

[sourcery-ai]

Hey - I've left some high level feedback:

• The test mutates the nsTLSAllowClientRenegotiation setting without restoring the original value, which can leak configuration changes into subsequent tests; consider saving the initial value and restoring it in a teardown/finally block.
• The if __name__ == '__main__': block is not needed for pytest-based tests and can be removed to keep the test module minimal.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test mutates the nsTLSAllowClientRenegotiation setting without restoring the original value, which can leak configuration changes into subsequent tests; consider saving the initial value and restoring it in a teardown/finally block.
- The `if __name__ == '__main__':` block is not needed for pytest-based tests and can be removed to keep the test module minimal.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/389ds-389-ds-base-7429
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[progier389]

LGTM