Issue 6753 - Removing ticket49412_test and porting to DSLdapObject

[aadhikar]

Description:
The old ticket49412_test.py had compatibility issues.
This ports the functionality to changelog_test.py
using modern Changelog5 class from lib389.

Relates: #6753

Reviewed by: ???
Assisted by: Claude

Summary by Sourcery

Migrate legacy changelog type validation coverage into the replication changelog test suite and remove the obsolete ticket-specific test file.

Tests:

• Add a replication changelog test that validates string-based maxage and trim interval configuration using the Changelog5 helper.
• Remove the deprecated ticket49412_test.py now that its coverage is provided in the changelog test suite.

[sourcery-ai]

Hey - I've left some high level feedback:

• The test mutates the changelog maxage and triminterval but never restores the original values; consider capturing the initial values and using a try/finally (or fixture) to reset the configuration to avoid cross-test side effects.
• The test name and docstring suggest validating types/values, but only the happy-path of valid string values is exercised; either extend the test to cover invalid values and expected failures or rename it to reflect that it only verifies valid value handling.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test mutates the changelog maxage and triminterval but never restores the original values; consider capturing the initial values and using a try/finally (or fixture) to reset the configuration to avoid cross-test side effects.
- The test name and docstring suggest validating types/values, but only the happy-path of valid string values is exercised; either extend the test to cover invalid values and expected failures or rename it to reflect that it only verifies valid value handling.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/389ds-389-ds-base-7428
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[aadhikar]

Note: changelog_test.py is not part of the CI test matrix. test_changelog_type_validation was verified locally and passes on both LMDB and BDB backends.

[mreynolds389]

I don't think the time unit "s" is supported. The trim interval is always in seconds. So just "10" is sufficient.

[aadhikar]

@mreynolds389
I believe 's' is supported, see is_valid_duration_unit(): https://github.com/389ds/389-ds-base/blob/main/ldap/servers/slapd/time.c#L716-L734

But happy to change it to just '10' if you would prefer keeping it without the unit.

[mreynolds389]

Indeed it's allowed, ok leave it as it.