Skip to content

brevo 환경변수 누락 수정 - #41

Merged
yoonjeonggg merged 1 commit into
mainfrom
fix/deploy-brevo-env
May 26, 2026
Merged

yoonjeonggg merged 1 commit into
mainfrom
fix/deploy-brevo-env

Conversation

@yoonjeonggg

@yoonjeonggg yoonjeonggg commented May 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration to enhance infrastructure reliability and scalability.

Review Change Stack

@yoonjeonggg
yoonjeonggg merged commit 529d55c into main May 26, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 26, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c877d707-257d-4a4c-8128-c5994493c94d

📥 Commits

Reviewing files that changed from the base of the PR and between f1f9f1c and 956066e.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

📝 Walkthrough

Walkthrough

The EC2 deployment workflow is updated to establish Docker networking topology by creating and connecting the gesture-net network to gesture-redis, and extends the container environment with Brevo API credentials (BREVO_API_KEY, BREVO_TEMPLATE_VERIFICATION_ID) while maintaining existing volume mounts.

Changes

EC2 Deployment Configuration

Layer / File(s) Summary
Docker network setup
.github/workflows/deploy.yml
EC2 SSH deploy script creates/validates the gesture-net Docker network if missing, connects gesture-net to gesture-redis, and updates docker run to explicitly use --network gesture-net.
Environment variables and container mount
.github/workflows/deploy.yml
Container environment configuration extended with BREVO_API_KEY and BREVO_TEMPLATE_VERIFICATION_ID environment variables; existing JWT key volume bind mount (/home/ubuntu/app/keys → /app/keys:ro) and image tag behavior unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Networking dreams and APIs bright,
Docker containers linked just right,
Brevo keys secured in place,
Deployment config keeps its grace,
A gesture-net of gestures kind! 🎭

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deploy-brevo-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant