fix: excel header gaps and formula evaluation - #47
Merged
Conversation
Ryan2486
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the Excel file import functionality by enhancing formula evaluation and handling of blank headers, and updates the related tests and test resources to support these features. The main changes are grouped into improvements to Excel decoding logic and enhancements to test coverage and maintainability.
Excel decoding logic improvements:
ExcelCodecclass now usesWorkbookFactory.createto support more Excel formats and properly closes resources, and it evaluates cell formulas when reading data. Columns with blank headers are now skipped, preventing them from being included in the parsed data. [1] [2]Test coverage and maintainability:
__level_room_teacher_teaching_unit_group.xlsx.jsonand__prof.xlsx.json) are added to support the updated and new tests. [1] [2]