Feat/migrate study levels & groups - #10
Open
Ryan2486 wants to merge 20 commits into
Open
Conversation
feat(app): update app configuration to include HTTP client feat(app): clean up app.html by removing placeholder content
…d simplify row value rendering
… in level component
# Conflicts: # src/app/app.config.ts # tsconfig.json
rivon0507
requested changes
Mar 4, 2026
rivon0507
left a comment
rivon0507
left a comment
Member
There was a problem hiding this comment.
Some concerns should be addressed so that we follow the angular coding style guide:
- we should use input signals instead of the
@Inputdecorator for component inputs. Here's how to migrate - we should use the
inject()function instead of the constructor injection for dependency injection. Here's how to migrate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces foundational changes for routing and API integration in the Angular app, laying the groundwork for future feature development. Key updates include setting up application routing to a new
LevelComponent, adding HTTP client support, and implementing a new API service for managing groups. Additionally, it removes the placeholder template and legacy license file, streamlining the codebase.Routing and App Structure
app.routes.ts, redirecting the root path to the newLevelComponentfor the/levelroute.app.htmlwith a minimal router outlet for dynamic content rendering.API Integration
provideHttpClient()to the app configuration to enable HTTP services across the app.GroupApiservice with CRUD methods for group management, using Angular'sHttpClient.Dependency and Model Updates
lucide-angulardependency topackage.json, preparing for future UI enhancements.levelAbrproperty from theGroupmodel.Cleanup