fix(anthropic): update deprecated default model and fix temperature/topP conflict#442
Open
guoyangzhen wants to merge 6 commits into
Open
fix(anthropic): update deprecated default model and fix temperature/topP conflict#442guoyangzhen wants to merge 6 commits into
guoyangzhen wants to merge 6 commits into
Conversation
|
Any update on merge ? |
Collaborator
|
Hey @guoyangzhen, two things must be fixed before this can merge. There is a stray `});` syntax error in `anthropicAgent.ts` — the file will not compile. In `anthropic_classifier.py`, the old constant `ANTHROPIC_MODEL_ID_CLAUDE_3_5_SONNET` is removed instead of kept alongside the new one — any user importing it will break. The new constant should be added while keeping the old one, the same way it is done correctly in `types/types.py`. CI has not run. Changing the default model is not an API break but it is a silent behavior change for users who do not pin `modelId` — worth a note in the changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues (#392):
claude-3-5-sonnet-20240620was deprecated on Oct 28, 2025temperatureandtopP, but newer Anthropic models reject requests with both parameters setFix
Model update
claude-sonnet-4-20250514(Claude 4 Sonnet)ANTHROPIC_MODEL_ID_CLAUDE_SONNET_4constant (Python + TypeScript)CLAUDE_3_5constant kept for backward compatibilitytemperature/topP conflict
topPfrom default configtop_pconditional in all API calls — only passed when explicitly set by usertopP: 0.9viainferenceConfigif their model supports itFiles changed (6)
python/.../agents/anthropic_agent.py— default model + conditional topPpython/.../classifiers/anthropic_classifier.py— samepython/.../types/types.py— new constanttypescript/.../agents/anthropicAgent.ts— same (Python fixes mirrored)typescript/.../classifiers/anthropicClassifier.ts— sametypescript/.../types/index.ts— new constantTesting
Closes #392