Skip to content

Missing tool and tool exception handling#251

Closed
brianantonelli wants to merge 1 commit into
2FastLabs:mainfrom
brianantonelli:tool-fix
Closed

Missing tool and tool exception handling#251
brianantonelli wants to merge 1 commit into
2FastLabs:mainfrom
brianantonelli:tool-fix

Conversation

@brianantonelli

Copy link
Copy Markdown

Issue number: #250

Summary

Missing tools should return a message that a requested tool was not found. Tools that throw exceptions should be properly caught and returned.

Changes

_process_tool in tools.py will raise exceptions for missing tools and tool invocation exceptions. tool_handler will catch these exceptions and report them back.

User experience

It works.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@cornelcroi

cornelcroi commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Hey @brianantonelli, closing this PR. PR #513 (now approved) already solves the same problem — fixing _process_tool error handling — in the correct agent_squad package path with the right approach. This one is superseded.

@cornelcroi cornelcroi closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants