CYS3-02: Upgradeable Storage Layout Changes Can Corrupt Live Proxies - #107
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit baa9ff3. Configure here.
evercoinx
force-pushed
the
serge/CYS3-02
branch
2 times, most recently
from
May 9, 2026 14:25
cd7685b to
3d3af87
Compare
dB2510
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk: changes are limited to tests and documentation, mainly adding regression coverage for upgrade safety and stabilizing fork tests against oracle staleness.
Overview
Adds a new
StorageLayout.t.solregression test that pins storage layouts for all mainnet-deployed UUPS proxies (PolicyManager,ClaimManager,PremiumManager,SpecRegistry,Swapper,CoverPoolFactory) by comparing FoundrystorageLayoutoutput against a baseline (with AST-ID normalization).Stabilizes Morpho fork tests by reducing
COVERAGE_LIMIT, wiringClaimManagerwithoraclePriceFeed+ a 10% deviation tolerance in the fork setup, and introducing_skipFork()which advances time while mocking ChainlinklatestRoundData()timestamps to avoid staleness reverts.Updates
AGENTS.mdwith explicit guidance on append-only state variable changes for deployed UUPS proxies and the requirement to update the pinned baselines alongside legitimate appends.Reviewed by Cursor Bugbot for commit 3d3af87. Bugbot is set up for automated code reviews on this repo. Configure here.