Repository navigation
chore(ci): add cargo-deny, wasm size budgets, and soroban-sdk consistency checks - #640
Merged
Elizabethxxx merged 2 commits intoOct 26, 2026
Conversation
…ency checks Add deny.toml and security.yml cargo-deny step (0xLizTech#91), contracts/size-budget.json (0xLizTech#94), scripts/check-wasm-size.cjs for CI WASM size tracking and PR delta reporting (0xLizTech#93), and scripts/check-soroban-sdk-version.cjs for workspace SDK version consistency (0xLizTech#95). Also resolve pre-existing merge conflict syntax and discriminant collisions across registry, oracle-adapter, governance, compliance, and benchmark crates.
noevidence1017
requested review from
Elizabethxxx and
promisszn
as code owners
October 22, 2026 11:39
|
@noevidence1017 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
OrderStream
reviewed
Oct 22, 2026
OrderStream
left a comment
OrderStream
left a comment
Contributor
There was a problem hiding this comment.
Very thorough security and build stability improvements:
- Permissive licensing gate: The deny.toml configuration appropriately allows Apache-2.0 and MIT while disallowing restrictive copyleft licenses, protecting downstream integrations.
- Contract WASM byte-budget checks: Adding size-budget.json and CI size delta checks is critical for Soroban deployments to prevent transaction footprint budget blowouts.
- SDK version consistency: Centrally pinning soroban-sdk in [workspace.dependencies] eliminates insidious runtime type mismatches between contract crates.
- Observation: Ensure CI compiles release profiles with opt-level = 'z' and lto = true prior to running the size check for accurate production binary measurement.
Looks solid.
# Conflicts: # CHANGELOG.md # CONTRIBUTING.md # contracts/governance/src/lib.rs # contracts/size-budget.json # deny.toml # docs/SECURITY.md
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
|
|
||
| const listUrl = `${apiUrl}/repos/${repo}/issues/${prNumber}/comments?per_page=100`; | ||
| const listRes = await fetchImpl(listUrl, { method: "GET", headers }); |
| const updateRes = await fetchImpl(updateUrl, { | ||
| method: "PATCH", | ||
| headers, | ||
| body: JSON.stringify({ body: markdown }), |
| } | ||
|
|
||
| const createUrl = `${apiUrl}/repos/${repo}/issues/${prNumber}/comments`; | ||
| const createRes = await fetchImpl(createUrl, { |
| const createRes = await fetchImpl(createUrl, { | ||
| method: "POST", | ||
| headers, | ||
| body: JSON.stringify({ body: markdown }), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Stage 1 repository, tooling, and CI developer experience issues:
wa-asset,
egistry, compliance, governance, oracle-adapter). Adds scripts/check-wasm-size.cjs and integrates it into .github/workflows/contracts-ci.yml to measure compiled .wasm sizes, report byte/KB deltas on pull requests, and fail the build when any contract exceeds its budget.
egistry, oracle-adapter, governance, compliance, and ools/benchmark.
Testing
ode scripts/check-wasm-size.cjs
ode scripts/check-soroban-sdk-version.cjs
closes #91
closes #93
closes #94
closes #95