Skip to content

Add cargo-deny configuration for licenses and bans #91

Closed

Description

@Elizabethxxx

Summary

Dependencies are audited for advisories but not for license compatibility.

Context

StellarForge is a Soroban workspace (contracts/*) plus a TypeScript SDK (sdk/). Phase 1 is feature complete, so this stage removes friction for new contributors and makes the toolchain trustworthy before more contracts land.

This issue belongs to Stage 1: Repository, Tooling and Developer Experience.

Objective

Deliver the change described above so that: cI fails when a GPL dependency is added.

Requirements

  • Add deny.toml allowing Apache-2.0, MIT, BSD
  • Deny unknown registries
  • Run cargo deny check in security.yml

Out of Scope

Changes to contract behavior or SDK public APIs unless the issue says so.

Acceptance Criteria

  • CI fails when a GPL dependency is added
  • CI is green and a maintainer has reviewed the change

Definition of Done

  • Findings, assumptions and residual risks are written down in docs/
  • The workflow runs green on a pull request and uses pinned action versions
  • The pull request links this issue and updates CHANGELOG.md when behavior changes

References

Activity

  1. Miraclechukwuemeka commented on Oct 15, 2026

    @Miraclechukwuemeka

    @Miraclechukwuemeka has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer, I would like to work on this issue. Kindly assign me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Miraclechukwuemeka to this issue.

  2. TheVictoriaAtteh commented on Oct 15, 2026

    @TheVictoriaAtteh

    @TheVictoriaAtteh has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer, I can work on this issue and submit PR within 1-2 days, please assign this to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @TheVictoriaAtteh to this issue.

  3. OrderStream commented on Oct 15, 2026

    @OrderStream
    Contributor

    @OrderStream has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Added strict Soroban contract address validation and error handling in PR #635. Please assign me first and then merge.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @OrderStream to this issue.

  4. OrderStream commented on Oct 20, 2026

    @OrderStream
    Contributor

    Hi @maintainer, I have applied on Drips Wave 10 and implemented cargo-deny configuration and security workflow check in PR #635. Please assign this issue to @OrderStream on GitHub and Drips Wave 10, and merge the PR. Thank you!

  5. OrderStream commented on Oct 21, 2026

    @OrderStream
    Contributor

    Hi @0xLizTech! PR #635 is ready for review with all CI checks passing.

    Please assign @OrderStream prior to merging so Wave 10 points are credited:
    👉 https://www.drips.network/wave/maintainers/issues/344ba27a-5c2f-488f-9a1b-419ea73099ea (or select @OrderStream under Assignees here on GitHub). Thank you!

  6. noevidence1017 commented on Oct 22, 2026

    @noevidence1017
    Contributor

    @noevidence1017 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hey! I'd love to contribute to this. The issue looks like something I can take on, and I'd be happy to put in the work to deliver a clean, working solution. Thanks for considering me!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @noevidence1017 to this issue.

  7. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @noevidence1017! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @noevidence1017: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  8. drips-wave commented on Oct 26, 2026

    @drips-wave

    This issue has been completed by @noevidence1017 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @noevidence1017: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions