Skip to content

Add pre-commit hooks for rustfmt and eslint #89

Closed

Description

@Elizabethxxx

Summary

Formatting failures reach CI because nothing runs locally.

Context

StellarForge is a Soroban workspace (contracts/*) plus a TypeScript SDK (sdk/). Phase 1 is feature complete, so this stage removes friction for new contributors and makes the toolchain trustworthy before more contracts land.

This issue belongs to Stage 1: Repository, Tooling and Developer Experience.

Objective

Deliver the change described above so that: a commit with bad formatting is rejected locally.

Requirements

  • Add a .pre-commit-config.yaml
  • Run cargo fmt --check and eslint on staged files
  • Document install steps

Out of Scope

Changes to contract behavior or SDK public APIs unless the issue says so.

Acceptance Criteria

  • A commit with bad formatting is rejected locally
  • CI is green and a maintainer has reviewed the change

Definition of Done

  • The tool runs from a clean checkout and its usage is documented
  • The pull request links this issue and updates CHANGELOG.md when behavior changes

References

Activity

  1. Clararosey67 commented on Oct 17, 2026

    @Clararosey67

    @Clararosey67 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d really love to work on this🥹💕 Please assign it to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Clararosey67 to this issue.

  2. OrderStream commented on Oct 21, 2026

    @OrderStream
    Contributor

    @OrderStream has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer, I will implement git pre-commit hooks running rustfmt and eslint with staged file filtering. Ready to submit a clean PR. Please assign to @OrderStream!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @OrderStream to this issue.

  3. OrderStream commented on Oct 21, 2026

    @OrderStream
    Contributor

    Hi @0xLizTech! I have implemented the pre-commit hooks and submitted PR #637 with complete rustfmt and eslint hook support, Makefile install target, and documentation updates.

    Please assign @OrderStream on Drips Wave so the points can be properly credited:
    👉 https://www.drips.network/wave/maintainers/issues/b5474e31-a45f-43d3-986c-76d7a327df86

    Thank you!

  4. Adeolu01 commented on Oct 22, 2026

    @Adeolu01
    Contributor

    @Adeolu01 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi! I'd like to take on this issue. I've reviewed the requirements and have a clear understanding of the expected changes. I have a solid implementation approach in mind and I'm confident I can deliver a clean, well-tested solution that fits the existing codebase.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Adeolu01 to this issue.

  5. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @Adeolu01! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Adeolu01: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. drips-wave commented on Oct 26, 2026

    @drips-wave

    This issue has been completed by @Adeolu01 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Adeolu01: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  7. added 4 commits that reference this issue on Oct 26, 2026
    0062994
    efeba30
    af81a25
    63a7730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions