Skip to content

ci(vold): qualify original pdx235 vold byte-for-byte before timeout patch - #161

Merged
0cwa merged 12 commits into
mainfrom
feature/vold-unmodified-baseline-ci-20261022
Oct 22, 2026
Merged

0cwa merged 12 commits into
mainfrom
feature/vold-unmodified-baseline-ci-20261022

Conversation

@0cwa

@0cwa 0cwa commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Stage 1 only — prove a byte-identical unmodified vold

This PR is intentionally independent of draft vold timeout module #157. It does not include or activate an exFAT timeout patch, vold injection, signing keys, release permissions, or scheduled OTA selections.

  • Pin the authentic LineageOS 24.0 2026-10-16 pdx235 source OTA SHA-256 and exact 1,243-project build manifest.
  • Authenticate downloaded OTA bytes, check the independent official LineageOS publisher key and complete OTA signature, and extract original /system/bin/vold as a reference.
  • From a clean, fully pinned source tree, build unmodified vold with lineage_pdx235-userdebug / m vold. Reject dirty or mismatched project revisions.
  • Compare every byte to the official reference. The small baseline-report.json records both SHA-256s, byte sizes, difference offset, manifest and source identity. Fail if even one byte differs.
  • Provide a manual-only, nonpublishing GitHub Actions workflow with read-only permissions, a 250 GB scratch-space gate, isolated modos-lineage-large runner label, guarded cleanup and a report-only artifact.
  • Add lightweight deterministic unit and contract tests to ordinary CI.

Important: CI unit tests verify the baseline workflow contract, not a real Android build. A real baseline requires a large, trusted self-hosted runner with MODOS_VOLD_BASELINE_RUNNER_READY=true and MODOS_LINEAGE_LARGE_SCRATCH configured. Until those are provisioned, the manual workflow cannot establish binary reproduction. The workflow is intentionally a manual trigger on main, so it becomes runnable after this safe infrastructure-only PR merges.

Once the actual CI run produces a independently reviewed byte_identical: true receipt, return to PR #157 for separate patched build, nonpublishing OTA, device tests and only then potential scheduled deployment. No force-publish is authorized by this PR.

Provisioning and acceptance: docs/vold-baseline-ci.md.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1374455a-7108-42a1-a75b-14f62c845977
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0cwa
0cwa merged commit 986e238 into main Oct 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant