Skip to content

Keep LineageOS pdx235 fsck and SELinux patches out of GrapheneOS - #160

Merged
0cwa merged 8 commits into
mainfrom
fix/grapheneos-pdx235-patch-isolation-20261021
Oct 21, 2026
Merged

0cwa merged 8 commits into
mainfrom
fix/grapheneos-pdx235-patch-isolation-20261021

Conversation

@0cwa

@0cwa 0cwa commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Scope

  • Explicitly turn off the exfatprogs-fsck and fsck-sysfs-sepolicy modules for both scheduled and manual GrapheneOS entry points.
  • Keep the GrapheneOS schedule TOML explicit about both disabled selectors.
  • Fail fast if the shared reusable build workflow is invoked with either module outside LineageOS pdx235, before checkout or signing.
  • Fail scheduled definition loading before exporting build inputs if either module is requested on an unsupported ROM/device.
  • Add contract regressions for both prohibited modules, both GrapheneOS selection IDs (shiba, synthetic pdx235), tampered GrapheneOS schedules, and explicit workflow-call values.

No LineageOS PDX235 selections are changed. The existing generic compatible-sepolicy-patching option is separate and not modified.

Vold remains separate: PR #157 is draft, has not been merged, and is not part of this PR. Do not merge it until separately approved.

Verification

Static branch diff reviewed for the seven intended files. GitHub PR CI should run tests/rom_contract_test.sh, tests/scheduled_build_definitions_test.sh, tests/workflow_contract_test.sh, and the remaining deterministic checks prior to merge.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b5a15669-3935-4f2d-b0f4-e80ac646ad07
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0cwa
0cwa merged commit c1a854d into main Oct 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant