🐛 fix(notification): use openSync/writeSync/closeSync for reliable tty writes

Replace writeFileSync with explicit openSync/writeSync/closeSync for
/dev/tty to work reliably in Bun's plugin execution context.

Remove escapeOSCString which could corrupt JSON payloads containing
semicolons.

Retain payload length truncation (4096 bytes) and 3-retry mechanism
with error logging.

Author: xiaogaozi

src/notify.ts

@@ -1,30 +1,22 @@
-import { writeFileSync } from "fs"
+import { openSync, writeSync, closeSync } from "fs"
 
 const MAX_OSC_LENGTH = 4096
 
-function escapeOSCString(str: string): string {
-  return str
-    .replace(/\x1b/g, "\x1b\x5d")
-    .replace(/\x07/g, "\x1b\x5c\x07")
-    .replace(/;/g, "\\;")
-}
-
 function warpNotify(title: string, body: string): void {
   if (!process.env.WARP_CLI_AGENT_PROTOCOL_VERSION) return
 
   const maxBodyLength = MAX_OSC_LENGTH - title.length - 20
-  const escapedBody = escapeOSCString(body)
   const truncatedBody =
-    escapedBody.length > maxBodyLength
-      ? escapedBody.slice(0, maxBodyLength - 3) + "..."
-      : escapedBody
+    body.length > maxBodyLength ? body.slice(0, maxBodyLength - 3) + "..." : body
 
   const sequence = `\x1b]777;notify;${title};${truncatedBody}\x07`
 
   let lastError: Error | null = null
   for (let attempt = 0; attempt < 3; attempt++) {
     try {
-      writeFileSync("/dev/tty", sequence)
+      const fd = openSync("/dev/tty", "w")
+      writeSync(fd, sequence)
+      closeSync(fd)
       return
     } catch (err) {
       lastError = err as Error

tests/notify.test.ts

@@ -2,10 +2,15 @@ import { describe, it, afterEach, mock } from "bun:test"
 import { expect } from "bun:test"
 import fs from "fs"
 
-const writeSpy = mock(() => {})
+const writeSyncSpy = mock(() => {})
+const openSyncSpy = mock(() => 42)
+const closeSyncSpy = mock(() => {})
+
 mock.module("fs", () => ({
   ...fs,
-  writeFileSync: writeSpy,
+  openSync: openSyncSpy,
+  writeSync: writeSyncSpy,
+  closeSync: closeSyncSpy,
 }))
 
 const { warpNotify } = await import("../src/notify")
@@ -14,7 +19,9 @@ describe("warpNotify", () => {
   const originalVersion = process.env.WARP_CLI_AGENT_PROTOCOL_VERSION
 
   afterEach(() => {
-    writeSpy.mockClear()
+    openSyncSpy.mockClear()
+    writeSyncSpy.mockClear()
+    closeSyncSpy.mockClear()
     if (originalVersion === undefined) {
       delete process.env.WARP_CLI_AGENT_PROTOCOL_VERSION
     } else {
@@ -25,19 +32,21 @@ describe("warpNotify", () => {
   it("skips when WARP_CLI_AGENT_PROTOCOL_VERSION is not set", () => {
     delete process.env.WARP_CLI_AGENT_PROTOCOL_VERSION
     warpNotify("title", "body")
-    expect(writeSpy).not.toHaveBeenCalled()
+    expect(openSyncSpy).not.toHaveBeenCalled()
   })
 
   it("writes OSC 777 sequence when Warp declares protocol support", () => {
     process.env.WARP_CLI_AGENT_PROTOCOL_VERSION = "1"
     warpNotify("warp://cli-agent", '{"event":"stop"}')
-    expect(writeSpy).toHaveBeenCalledTimes(1)
+    expect(openSyncSpy).toHaveBeenCalledTimes(1)
+    expect(openSyncSpy).toHaveBeenCalledWith("/dev/tty", "w")
+    expect(writeSyncSpy).toHaveBeenCalledTimes(1)
+    expect(closeSyncSpy).toHaveBeenCalledTimes(1)
 
-    const [path, data] = writeSpy.mock.calls[0] as [string, string]
-    expect(path).toBe("/dev/tty")
+    const [, data] = writeSyncSpy.mock.calls[0] as [number, string]
     expect(data).toContain("warp://cli-agent")
     expect(data).toContain('{"event":"stop"}')
     expect(data).toMatch(/^\x1b\]777;notify;/)
     expect(data).toMatch(/\x07$/)
   })
-})
+})