Remove a few applicationIconBadgeNumber API calls (#24877)

Author: crazytonyli

Tests/KeystoneTests/Tests/Features/Notifications/NotificationsViewControllerTests.swift

@@ -1,5 +1,6 @@
 import XCTest
 import WordPressData
+import UserNotifications
 @testable import WordPress
 
 final class NotificationsViewControllerTests: XCTestCase {
@@ -46,7 +47,7 @@ final class NotificationsViewControllerTests: XCTestCase {
     func testResetApplicationBadgeWhenAccountChange() throws {
         // Give
         let newUnreadCount = 1
-        UIApplication.shared.applicationIconBadgeNumber = 0
+        UNUserNotificationCenter.current().setBadgeCount(0)
         ZendeskUtils.unreadNotificationsCount = newUnreadCount
 
         // When

WordPress/Classes/Utility/Notifications/PushNotificationsManager.swift

@@ -75,7 +75,7 @@ public final class PushNotificationsManager: NSObject {
             sharedApplication.registerForRemoteNotifications()
         }
         sharedApplication.unregisterForRemoteNotifications()
-        sharedApplication.applicationIconBadgeNumber = 0
+        UNUserNotificationCenter.current().setBadgeCount(0)
         didRegisterForRemoteNotifications = false
     }
 
@@ -187,7 +187,7 @@ public final class PushNotificationsManager: NSObject {
 
         // Badge: Update
         if let badgeCountNumber = userInfo.number(forKeyPath: Notification.badgePath)?.intValue {
-            sharedApplication.applicationIconBadgeNumber = badgeCountNumber
+            UNUserNotificationCenter.current().setBadgeCount(badgeCountNumber)
         }
 
         // Badge: Reset

WordPress/Classes/Utility/ZendeskUtils.swift

@@ -307,7 +307,7 @@ class ZendeskUtils: NSObject, ZendeskUtilsProtocol {
     /// - post an NSNotification so the various indicators can be cleared.
     ///
     static func pushNotificationRead() {
-        UIApplication.shared.applicationIconBadgeNumber -= unreadNotificationsCount
+        UNUserNotificationCenter.current().setBadgeCount(UIApplication.shared.applicationIconBadgeNumber - unreadNotificationsCount)
         unreadNotificationsCount = 0
         saveUnreadCount()
         postNotificationRead()

WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController/NotificationsViewController.swift

@@ -8,6 +8,7 @@ import Gridicons
 import UIKit
 import WordPressUI
 import SwiftUI
+import UserNotifications
 
 /// The purpose of this class is to render the collection of Notifications, associated to the main
 /// WordPress.com account.
@@ -1720,7 +1721,7 @@ private extension NotificationsViewController {
     func resetApplicationBadge() {
         // These notifications are cleared, so we just need to take Zendesk unread notifications
         // into account when setting the app icon count.
-        UIApplication.shared.applicationIconBadgeNumber = ZendeskUtils.unreadNotificationsCount
+        UNUserNotificationCenter.current().setBadgeCount(ZendeskUtils.unreadNotificationsCount)
     }
 }
 

WordPress/Classes/ViewRelated/System/WPTabBarController.m

@@ -356,7 +356,11 @@ - (void)updateNotificationBadgeVisibility
     }
 
     // Discount Zendesk unread notifications when determining if we need to show the notificationsTabBarImageUnread.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     NSInteger count = [[UIApplication sharedApplication] applicationIconBadgeNumber] - ObjCBridge.unreadNotificationsCount;
+#pragma clang diagnostic pop
+
     if (count > 0 || ![self welcomeNotificationSeen]) {
         notificationsTabBarItem.image = self.notificationsTabBarImageUnread;
         notificationsTabBarItem.accessibilityLabel = NSLocalizedString(@"Notifications Unread", @"Notifications tab bar item accessibility label, unread notifications state");