Remove iOS 16 and 17 availablity check (#24874)

* Change the iOS platform version in the Modules package

* Remove iOS 17 availablity checks

* Remove iOS 16 availablity checks

* Remove `ColorGallery`

* Remove some oneline funtions

Author: crazytonyli

Modules/Package.swift

@@ -5,7 +5,7 @@ import PackageDescription
 let package = Package(
     name: "Modules",
     platforms: [
-        .iOS(.v16),
+        .iOS(.v17),
     ],
     products: XcodeSupport.products + [
         .library(name: "AsyncImageKit", targets: ["AsyncImageKit"]),

Modules/Sources/DesignSystem/Components/FAB.swift

@@ -58,7 +58,6 @@ private struct FABContentView: View {
     }
 }
 
-@available(iOS 17, *)
 #Preview(traits: .fixedLayout(width: 200, height: 200)) {
     FAB(action: {})
 }

Modules/Sources/DesignSystem/Gallery/ColorGallery.swift

@@ -13,7 +13,6 @@ public struct DesignSystemGallery: View {
 
     private var foundationList: some View {
         List {
-            NavigationLink("Colors", destination: ColorGallery())
             NavigationLink("Fonts", destination: FontGallery())
             NavigationLink("Lengths", destination: LengthGallery())
         }

Modules/Sources/DesignSystem/Gallery/DesignSystemGallery.swift

@@ -142,7 +142,7 @@ struct BarChartView: View {
 
     @ChartContentBuilder
     private var selectionIndicatorMarks: some ChartContent {
-        if #available(iOS 17.0, *), let selectedDataPoints {
+        if let selectedDataPoints {
             if let currentPoint = selectedDataPoints.current {
                 RuleMark(x: .value("Selected", currentPoint.date))
                     .foregroundStyle(Color.clear)

Modules/Sources/JetpackStats/Charts/BarChartView.swift

@@ -32,7 +32,7 @@ struct LineChartView: View {
         .chartYScale(domain: yAxisDomain)
         .chartLegend(.hidden)
         .environment(\.timeZone, context.timeZone)
-        .modifier(ChartSelectionModifier(selection: $selectedDate))
+        .chartXSelection(value: $selectedDate)
         .animation(.spring, value: ObjectIdentifier(data))
         .onChange(of: selectedDate) {
             selectedDataPoints = SelectedDataPoints.compute(for: $0, data: data)
@@ -139,7 +139,7 @@ struct LineChartView: View {
 
     @ChartContentBuilder
     private var selectionIndicatorMarks: some ChartContent {
-        if #available(iOS 17.0, *), let selectedDataPoints {
+        if let selectedDataPoints {
             if let currentPoint = selectedDataPoints.current {
                 RuleMark(x: .value("Selected", currentPoint.date))
                     .foregroundStyle(Color.secondary.opacity(0.33))

Modules/Sources/JetpackStats/Charts/LineChartView.swift

@@ -151,7 +151,7 @@ struct TrafficTabView: View {
                 viewModel.addCard(type: cardType)
             }
             .dynamicTypeSize(...DynamicTypeSize.xLarge)
-            .modifier(PopoverPresentationModifier())
+            .presentationCompactAdaptation(.popover)
         }
     }
 

Modules/Sources/JetpackStats/Screens/TrafficTabView.swift

@@ -77,11 +77,7 @@ struct CSVDataRepresentation: Transferable {
         let dataRepresentation = DataRepresentation(exportedContentType: .commaSeparatedText) { (representation: CSVDataRepresentation) in
             try representation.generateCSVData()
         }
-        if #available(iOS 17.0, *) {
-            return dataRepresentation.suggestedFileName { $0.fileName }
-        } else {
-            return dataRepresentation
-        }
+        return dataRepresentation.suggestedFileName { $0.fileName }
     }
 
     private func generateCSVData() throws -> Data {
@@ -103,15 +99,11 @@ struct ChartDataCSVRepresentation: Transferable {
         let dataRepresentation = DataRepresentation(exportedContentType: .commaSeparatedText) { (representation: ChartDataCSVRepresentation) in
             try representation.generateCSVData()
         }
-        if #available(iOS 17.0, *) {
-            return dataRepresentation.suggestedFileName { representation in
-                let dateString = representation.context.formatters.dateRange.string(from: representation.dateRange.dateInterval)
-                    .replacingOccurrences(of: "/", with: "-")
-                    .replacingOccurrences(of: ",", with: "")
-                return "\(representation.data.metric.localizedTitle)-\(dateString).csv"
-            }
-        } else {
-            return dataRepresentation
+        return dataRepresentation.suggestedFileName { representation in
+            let dateString = representation.context.formatters.dateRange.string(from: representation.dateRange.dateInterval)
+                .replacingOccurrences(of: "/", with: "-")
+                .replacingOccurrences(of: ",", with: "")
+            return "\(representation.data.metric.localizedTitle)-\(dateString).csv"
         }
     }