Skip to content

Commit faebb62

Browse files
committed
Fixed test regressions
1 parent e48c1eb commit faebb62

4 files changed

Lines changed: 22 additions & 6 deletions

File tree

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ include/target.h
114114
.wolfboot-offset
115115
.wolfboot-partition-size
116116
.bootloader-partition-size
117+
NVChip
117118
MPLabX/wolfBoot-SAME51.X/.generated_files/
118119
test-dummy-ca/**
119120

@@ -183,6 +184,9 @@ tools/unit-tests/unit-update-flash-delta
183184
tools/unit-tests/unit-update-flash-self-update
184185
tools/unit-tests/unit-loader-tpm-init
185186
tools/unit-tests/unit-update-ram-nofixed
187+
tools/unit-tests/unit-max-space
188+
tools/unit-tests/unit-sdhci-disk-unaligned
189+
186190

187191

188192

@@ -376,4 +380,3 @@ system-default.dtb
376380
test_output/
377381
sdcard.img
378382

379-

src/tpm.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,13 +355,14 @@ int wolfBoot_tpm2_extend(uint8_t pcrIndex, uint8_t* hash, int line)
355355
TPM2_GetHashDigestSize(WOLFBOOT_TPM_PCR_ALG));
356356
#ifdef WOLFBOOT_DEBUG_TPM
357357
if (rc == 0) {
358+
int read_rc;
358359
wolfBoot_printf("Measured boot: Index %d, Line %d\n", pcrIndex, line);
359360

360-
rc = wolfTPM2_ReadPCR(&wolftpm_dev, pcrIndex, WOLFBOOT_TPM_PCR_ALG,
361+
read_rc = wolfTPM2_ReadPCR(&wolftpm_dev, pcrIndex, WOLFBOOT_TPM_PCR_ALG,
361362
digest, &digestSz);
362363

363364
wolfBoot_printf("PCR %d: Res %d, Digest Sz %d\n",
364-
pcrIndex, rc, digestSz);
365+
pcrIndex, read_rc, digestSz);
365366
wolfBoot_print_bin(digest, digestSz);
366367
}
367368
else {

src/update_flash.c

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,18 @@ static int RAMFUNCTION wolfBoot_swap_and_final_erase(int resume)
567567
# define DELTA_BLOCK_SIZE 1024
568568
#endif
569569

570+
static inline uint32_t wb_im2n32(uint32_t val)
571+
{
572+
#ifdef BIG_ENDIAN_ORDER
573+
return val;
574+
#else
575+
return (((val & 0x000000FFU) << 24) |
576+
((val & 0x0000FF00U) << 8) |
577+
((val & 0x00FF0000U) >> 8) |
578+
((val & 0xFF000000U) >> 24));
579+
#endif
580+
}
581+
570582
static int wolfBoot_delta_update(struct wolfBoot_image *boot,
571583
struct wolfBoot_image *update, struct wolfBoot_image *swap, int inverse,
572584
int resume)
@@ -619,9 +631,9 @@ static int wolfBoot_delta_update(struct wolfBoot_image *boot,
619631
&delta_base_hash, &delta_base_hash_sz) < 0) {
620632
return -1;
621633
}
622-
delta_img_size = im2n(*img_size);
634+
delta_img_size = wb_im2n32(*img_size);
623635
if (inverse)
624-
delta_img_offset = im2n(*img_offset);
636+
delta_img_offset = wb_im2n32(*img_offset);
625637
cur_v = wolfBoot_current_firmware_version();
626638
upd_v = wolfBoot_update_firmware_version();
627639
delta_base_v = wolfBoot_get_diffbase_version(PART_UPDATE);

tools/unit-tests/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ unit-boot-x86-fsp: ../../include/target.h unit-boot-x86_fsp.c
240240
-Wl,--gc-sections
241241

242242
unit-loader-tpm-init: ../../include/target.h unit-loader-tpm-init.c
243-
gcc -o $@ $^ $(CFLAGS) -DWOLFBOOT_LOADER_MAIN -DWOLFBOOT_TPM \
243+
gcc -o $@ $^ $(CFLAGS) -I$(WOLFBOOT_LIB_WOLFTPM) -DWOLFBOOT_LOADER_MAIN -DWOLFBOOT_TPM \
244244
-DWOLFBOOT_HOOK_PANIC -DWOLFBOOT_SIGN_ECC256 \
245245
-DWOLFBOOT_HASH_SHA256 -ffunction-sections -fdata-sections \
246246
$(LDFLAGS) -Wl,--gc-sections

0 commit comments

Comments
 (0)