(review comment) remove hal_otp.h

Author: danielinux

hal/stm32h5.c

@@ -25,7 +25,6 @@
 #include <string.h>
 
 #include "hal.h"
-#include "hal_otp.h"
 #include "hal/stm32h5.h"
 #include "hal/armv8m_tz.h"
 
@@ -765,7 +764,7 @@ void hal_prepare_boot(void)
 int hal_flash_otp_set_readonly(uint32_t flashAddress, uint16_t length)
 {
     uint32_t start_block = (flashAddress - FLASH_OTP_BASE) / FLASH_OTP_BLOCK_SIZE;
-    uint32_t count = hal_otp_blocks_for_length(length, FLASH_OTP_BLOCK_SIZE);
+    uint32_t count = (length + FLASH_OTP_BLOCK_SIZE - 1U) / FLASH_OTP_BLOCK_SIZE;
     uint32_t bmap = 0;
     unsigned int i;
     if (start_block + count > 32)

include/hal_otp.h

@@ -49,7 +49,7 @@ TESTS:=unit-parser unit-fdt unit-extflash unit-string unit-spi-flash unit-aes128
        unit-update-flash-enc unit-update-ram unit-pkcs11_store unit-psa_store unit-disk \
        unit-update-disk unit-multiboot unit-boot-x86-fsp unit-qspi-flash unit-tpm-rsa-exp \
        unit-image-nopart unit-image-sha384 unit-image-sha3-384 unit-store-sbrk \
-       unit-tpm-blob unit-policy-sign unit-rot-auth unit-sdhci-response-bits unit-hal-otp
+       unit-tpm-blob unit-policy-sign unit-rot-auth unit-sdhci-response-bits
 TESTS+=unit-tpm-check-rot-auth
 
 all: $(TESTS)
@@ -167,9 +167,6 @@ unit-sdhci-response-bits: ../../include/target.h unit-sdhci-response-bits.c
 	gcc -o $@ $^ $(CFLAGS) -ffunction-sections -fdata-sections $(LDFLAGS) \
 		-Wl,--gc-sections
 
-unit-hal-otp: ../../include/target.h unit-hal-otp.c
-	gcc -o $@ $^ $(CFLAGS) $(LDFLAGS)
-
 unit-aes128: ../../include/target.h unit-extflash.c
 	gcc -o $@ $^ $(CFLAGS) $(LDFLAGS)