2fa: log error on totp mismatch (apache#10734)

shwstppr · web-flow · commit 6868f052de49 · 2025-09-08T11:06:22.000+02:00
Addresses apache#9515 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
diff --git a/plugins/user-two-factor-authenticators/totp/src/main/java/org/apache/cloudstack/auth/TotpUserTwoFactorAuthenticator.java b/plugins/user-two-factor-authenticators/totp/src/main/java/org/apache/cloudstack/auth/TotpUserTwoFactorAuthenticator.java
@@ -54,7 +54,9 @@ public void check2FA(String code, UserAccount userAccount) throws CloudTwoFactor
             logger.info("2FA matches user's input");
             return;
         }
-        throw new CloudTwoFactorAuthenticationException("two-factor authentication code provided is invalid");
+        String msg = "two-factor authentication code provided is invalid";
+        logger.error(msg);
+        throw new CloudTwoFactorAuthenticationException(msg);
     }
 
     private String get2FAKey(UserAccount userAccount) {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ public void check2FA(String code, UserAccount userAccount) throws CloudTwoFactor`
`54`	`54`	`logger.info("2FA matches user's input");`
`55`	`55`	`return;`
`56`	`56`	`}`
`57`		`- throw new CloudTwoFactorAuthenticationException("two-factor authentication code provided is invalid");`
	`57`	`+ String msg = "two-factor authentication code provided is invalid";`
	`58`	`+ logger.error(msg);`
	`59`	`+ throw new CloudTwoFactorAuthenticationException(msg);`
`58`	`60`	`}`
`59`	`61`
`60`	`62`	`private String get2FAKey(UserAccount userAccount) {`