add logging to deployment planners (apache#5859)

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Author: 4 people

api/src/main/java/org/apache/cloudstack/api/BaseCmd.java

@@ -355,7 +355,7 @@ public List<Field> getParamFields() {
             if (roleIsAllowed) {
                 validFields.add(field);
             } else {
-                s_logger.debug("Ignoring paremeter " + parameterAnnotation.name() + " as the caller is not authorized to pass it in");
+                s_logger.debug("Ignoring parameter " + parameterAnnotation.name() + " as the caller is not authorized to pass it in");
             }
         }
 

engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java

@@ -221,7 +221,7 @@ public String reserveVirtualMachine(VMEntityVO vmEntityVO, DeploymentPlanner pla
                 // call retry it.
                 return UUID.randomUUID().toString();
             } else {
-                throw new InsufficientServerCapacityException("Unable to create a deployment for " + vmProfile, DataCenter.class, plan.getDataCenterId(),
+                throw new InsufficientServerCapacityException("No destination found for a deployment for " + vmProfile, DataCenter.class, plan.getDataCenterId(),
                     areAffinityGroupsAssociated(vmProfile));
             }
         }

plugins/affinity-group-processors/explicit-dedication/src/main/java/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java

@@ -305,6 +305,9 @@ private ExcludeList updateAvoidList(List<DedicatedResourceVO> dedicatedResources
                 for (HostPodVO pod : podList) {
                     DedicatedResourceVO dPod = _dedicatedDao.findByPodId(pod.getId());
                     if (dPod != null && !dedicatedResources.contains(dPod)) {
+                        if (s_logger.isDebugEnabled()) {
+                            s_logger.debug(String.format("Avoiding POD %s [%s] because it is not dedicated.", pod.getName(), pod.getUuid()));
+                        }
                         avoidList.addPod(pod.getId());
                     } else {
                         includeList.addPod(pod.getId());
@@ -343,6 +346,9 @@ private ExcludeList updateAvoidList(List<DedicatedResourceVO> dedicatedResources
 
         for (HostPodVO pod : pods) {
             if (podsInIncludeList != null && !podsInIncludeList.contains(pod.getId())) {
+                if (s_logger.isDebugEnabled()) {
+                    s_logger.debug(String.format("Avoiding POD %s [%s], as it is not in include list.", pod.getName(), pod.getUuid()));
+                }
                 avoidList.addPod(pod.getId());
             }
         }

plugins/deployment-planners/implicit-dedication/src/main/java/com/cloud/deploy/ImplicitDedicationPlanner.java

@@ -107,7 +107,7 @@ public List<Long> orderClusters(VirtualMachineProfile vmProfile, DeploymentPlan
             }
         }
 
-        // Hosts running vms of other accounts created by ab implicit planner in strict mode should always be avoided.
+        // Hosts running vms of other accounts created by an implicit planner in strict mode should always be avoided.
         avoid.addHostList(hostRunningStrictImplicitVmsOfOtherAccounts);
 
         if (!hostRunningVmsOfAccount.isEmpty() && (hostsToAvoid == null || !hostsToAvoid.containsAll(hostRunningVmsOfAccount))) {

server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java

@@ -754,9 +754,17 @@ public void checkForNonDedicatedResources(VirtualMachineProfile vmProfile, DataC
         //Only when the type is instance VM and not explicitly dedicated.
         if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
             //add explicitly dedicated resources in avoidList
-
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Adding pods to avoid lists for non-explicit VM deployment: " + allPodsInDc);
+            }
             avoids.addPodList(allPodsInDc);
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Adding clusters to avoid lists for non-explicit VM deployment: " + allClustersInDc);
+            }
             avoids.addClusterList(allClustersInDc);
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Adding hosts to avoid lists for non-explicit VM deployment: " + allHostsInDc);
+            }
             avoids.addHostList(allHostsInDc);
         }
 
@@ -835,8 +843,17 @@ public void checkForNonDedicatedResources(VirtualMachineProfile vmProfile, DataC
             }
 
             //Add in avoid list or no addition if no dedication
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Adding pods to avoid lists: " + allPodsInDc);
+            }
             avoids.addPodList(allPodsInDc);
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Adding clusters to avoid lists: " + allClustersInDc);
+            }
             avoids.addClusterList(allClustersInDc);
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("Adding hosts to avoid lists: " + allHostsInDc);
+            }
             avoids.addHostList(allHostsInDc);
         }
     }

ui/public/locales/en.json

@@ -1674,7 +1674,7 @@
 "label.powerflex.gateway.username": "Gateway Username",
 "label.powerflex.storage.pool": "Storage Pool",
 "label.powerstate": "Power State",
-"label.preferred": "Prefered",
+"label.preferred": "Preferred",
 "label.presetup": "PreSetup",
 "label.prev": "Prev",
 "label.previous": "Previous",

ui/src/views/offering/AddComputeOffering.vue

@@ -394,7 +394,7 @@
             <a-radio-button value="strict">
               {{ $t('label.strict') }}
             </a-radio-button>
-            <a-radio-button value="preferred">
+            <a-radio-button value="Preferred">
               {{ $t('label.preferred') }}
             </a-radio-button>
           </a-radio-group>