chore: fix lint

Author: ersachin3112

.github/workflows/nodejs.yml

@@ -43,7 +43,7 @@ jobs:
           cache: "npm"
 
       - name: Install dependencies
-        run: npm install
+        run: npm ci
 
       - name: Lint
         run: npm run lint
@@ -90,7 +90,7 @@ jobs:
           cache: "npm"
 
       - name: Install dependencies
-        run: npm install
+        run: npm ci
 
       - name: Install webpack ${{ matrix.webpack-version }}
         if: matrix.webpack-version != 'latest'

eslint.config.mjs

@@ -1,26 +1,8 @@
 import { defineConfig } from "eslint/config";
 import configs from "eslint-config-webpack/configs.js";
-import n from "eslint-plugin-n";
 
 export default defineConfig([
   {
     extends: [configs["recommended-dirty"]],
-    plugins: {
-      n,
-    },
-    rules: {
-      // Disable experimental Node.js API warnings for os.availableParallelism
-      // This API is widely supported and stable in practice
-      "n/no-unsupported-features/node-builtins": [
-        "error",
-        {
-          ignores: ["os.availableParallelism"],
-        },
-      ],
-      // Disable problematic unicorn rules to work around security vulnerabilities
-      "unicorn/no-unnecessary-array-flat-depth": "off",
-      "unicorn/no-unnecessary-array-splice-count": "off",
-      "unicorn/no-useless-fallback-in-spread": "off",
-    },
   },
 ]);

src/index.js

@@ -31,35 +31,35 @@ const {
 
 /**
  * @typedef {Record<string, unknown>} CssNanoOptions
- * @property {string=} configFile - Configuration file path
- * @property {string | [string, Record<string, unknown>] | undefined=} preset - CSS nano preset
+ * @property {string=} configFile Configuration file path
+ * @property {string | [string, Record<string, unknown>] | undefined=} preset CSS nano preset
  */
 
 /** @typedef {Error & { plugin?: string, text?: string, source?: string } | string} Warning */
 
 /**
  * @typedef {object} WarningObject
- * @property {string} message - Warning message
- * @property {string=} plugin - Plugin name
- * @property {string=} text - Warning text
- * @property {number=} line - Line number
- * @property {number=} column - Column number
+ * @property {string} message Warning message
+ * @property {string=} plugin Plugin name
+ * @property {string=} text Warning text
+ * @property {number=} line Line number
+ * @property {number=} column Column number
  */
 
 /**
  * @typedef {object} ErrorObject
- * @property {string} message - Error message
- * @property {number=} line - Line number
- * @property {number=} column - Column number
- * @property {string=} stack - Error stack trace
+ * @property {string} message Error message
+ * @property {number=} line Line number
+ * @property {number=} column Column number
+ * @property {string=} stack Error stack trace
  */
 
 /**
  * @typedef {object} MinimizedResult
- * @property {string} code - Minimized code
- * @property {RawSourceMap=} map - Source map
- * @property {Array<Error | ErrorObject| string>=} errors - Errors
- * @property {Array<Warning | WarningObject | string>=} warnings - Warnings
+ * @property {string} code Minimized code
+ * @property {RawSourceMap=} map Source map
+ * @property {Array<Error | ErrorObject| string>=} errors Errors
+ * @property {Array<Warning | WarningObject | string>=} warnings Warnings
  */
 
 /**
@@ -91,7 +91,7 @@ const {
 
 /**
  * @typedef {object} MinimizeFunctionHelpers
- * @property {() => boolean | undefined=} supportsWorkerThreads - Check if worker threads are supported
+ * @property {() => boolean | undefined=} supportsWorkerThreads Check if worker threads are supported
  */
 
 /**
@@ -102,10 +102,10 @@ const {
 /**
  * @template T
  * @typedef {object} InternalOptions
- * @property {string} name - Name
- * @property {string} input - Input
- * @property {RawSourceMap | undefined} inputSourceMap - Input source map
- * @property {{ implementation: MinimizerImplementation<T>, options: MinimizerOptions<T> }} minimizer - Minimizer
+ * @property {string} name Name
+ * @property {string} input Input
+ * @property {RawSourceMap | undefined} inputSourceMap Input source map
+ * @property {{ implementation: MinimizerImplementation<T>, options: MinimizerOptions<T> }} minimizer Minimizer
  */
 
 /**
@@ -124,11 +124,11 @@ const {
 
 /**
  * @typedef {object} BasePluginOptions
- * @property {Rule=} test - Test rule
- * @property {Rule=} include - Include rule
- * @property {Rule=} exclude - Exclude rule
- * @property {WarningsFilter=} warningsFilter - Warnings filter
- * @property {Parallel=} parallel - Parallel option
+ * @property {Rule=} test Test rule
+ * @property {Rule=} include Include rule
+ * @property {Rule=} exclude Exclude rule
+ * @property {WarningsFilter=} warningsFilter Warnings filter
+ * @property {Parallel=} parallel Parallel option
  */
 
 /**
@@ -202,7 +202,7 @@ class CssMinimizerPlugin {
   /**
    * @private
    * @param {unknown} input Input to check
-   * @returns {boolean} - Whether input is a source map
+   * @returns {boolean} Whether input is a source map
    */
   static isSourceMap(input) {
     // All required options for `new SourceMapConsumer(...options)`
@@ -226,7 +226,7 @@ class CssMinimizerPlugin {
    * @param {WarningsFilter=} warningsFilter Warnings filter
    * @param {TraceMap=} sourceMap Source map
    * @param {Compilation["requestShortener"]=} requestShortener Request shortener
-   * @returns {Error & { hideStack?: boolean, file?: string } | undefined} - Built warning
+   * @returns {Error & { hideStack?: boolean, file?: string } | undefined} Built warning
    */
   static buildWarning(
     warning,
@@ -309,7 +309,7 @@ class CssMinimizerPlugin {
    * @param {string} file File name
    * @param {TraceMap=} sourceMap Source map
    * @param {Compilation["requestShortener"]=} requestShortener Request shortener
-   * @returns {Error} - Built error
+   * @returns {Error} Built error
    */
   static buildError(error, file, sourceMap, requestShortener) {
     /**
@@ -384,15 +384,17 @@ class CssMinimizerPlugin {
   /**
    * @private
    * @param {Parallel} parallel Parallel option
-   * @returns {number} - Available number of cores
+   * @returns {number} Available number of cores
    */
   static getAvailableNumberOfCores(parallel) {
     // In some cases cpus() returns undefined
     // https://github.com/nodejs/node/issues/19022
 
     const cpus =
+      // eslint-disable-next-line n/no-unsupported-features/node-builtins
       typeof os.availableParallelism === "function"
-        ? { length: os.availableParallelism() }
+        ? // eslint-disable-next-line n/no-unsupported-features/node-builtins
+          { length: os.availableParallelism() }
         : os.cpus() || { length: 1 };
 
     return parallel === true || typeof parallel === "undefined"
@@ -404,7 +406,7 @@ class CssMinimizerPlugin {
    * @private
    * @template T
    * @param {BasicMinimizerImplementation<T> & MinimizeFunctionHelpers} implementation Implementation
-   * @returns {boolean} - Whether worker threads are supported
+   * @returns {boolean} Whether worker threads are supported
    */
   static isSupportsWorkerThreads(implementation) {
     return typeof implementation.supportsWorkerThreads !== "undefined"
@@ -418,7 +420,7 @@ class CssMinimizerPlugin {
    * @param {Compilation} compilation Compilation
    * @param {Record<string, import("webpack").sources.Source>} assets Assets
    * @param {{availableNumberOfCores: number}} optimizeOptions Optimize options
-   * @returns {Promise<void>} - Promise
+   * @returns {Promise<void>} Promise
    */
   async optimize(compiler, compilation, assets, optimizeOptions) {
     const cache = compilation.getCache("CssMinimizerWebpackPlugin");
@@ -709,7 +711,7 @@ class CssMinimizerPlugin {
 
   /**
    * @param {Compiler} compiler Compiler
-   * @returns {void} - Void
+   * @returns {void} Void
    */
   apply(compiler) {
     const pluginName = this.constructor.name;

src/minify.js

@@ -4,7 +4,7 @@
 /**
  * @template T
  * @param {import("./index.js").InternalOptions<T>} options Options
- * @returns {Promise<InternalResult>} - Promise with internal result
+ * @returns {Promise<InternalResult>} Promise with internal result
  */
 async function minify(options) {
   const minifyFns = Array.isArray(options.minimizer.implementation)
@@ -63,7 +63,7 @@ async function minify(options) {
 
 /**
  * @param {string} options Options string
- * @returns {Promise<InternalResult>} - Promise with internal result
+ * @returns {Promise<InternalResult>} Promise with internal result
  */
 async function transform(options) {
   // 'use strict' => this === undefined (Clean Scope)

src/utils.js

@@ -73,7 +73,7 @@ function throttleAll(limit, tasks) {
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function cssnanoMinify(
   input,
@@ -83,7 +83,7 @@ async function cssnanoMinify(
   /**
    * @template T
    * @param {string} module Module to load
-   * @returns {Promise<T>} - Promise with loaded module
+   * @returns {Promise<T>} Promise with loaded module
    */
   const load = async (module) => {
     let exports;
@@ -120,7 +120,10 @@ async function cssnanoMinify(
   /** @type {ProcessOptions} */
   const postcssOptions = {
     from: name,
-    ...(minimizerOptions.processorOptions || {}),
+    ...(minimizerOptions.processorOptions &&
+    typeof minimizerOptions.processorOptions === "object"
+      ? minimizerOptions.processorOptions
+      : {}),
   };
 
   if (typeof postcssOptions.parser === "string") {
@@ -194,7 +197,7 @@ cssnanoMinify.supportsWorkerThreads = () => true;
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function cssoMinify(input, sourceMap, minimizerOptions) {
   const csso = require("csso");
@@ -223,7 +226,7 @@ cssoMinify.supportsWorkerThreads = () => true;
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function cleanCssMinify(input, sourceMap, minimizerOptions) {
   const CleanCSS = require("clean-css");
@@ -249,7 +252,7 @@ async function cleanCssMinify(input, sourceMap, minimizerOptions) {
     generatedSourceMap.sources = generatedSourceMap.sources.map(
       /**
        * @param {string | null} item Path item
-       * @returns {string} - Normalized path
+       * @returns {string} Normalized path
        */
       (item) =>
         isWindowsPathSep ? (item || "").replaceAll("\\", "/") : item || "",
@@ -270,12 +273,12 @@ cleanCssMinify.supportsWorkerThreads = () => true;
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function esbuildMinify(input, sourceMap, minimizerOptions) {
   /**
    * @param {import("esbuild").TransformOptions=} esbuildOptions ESBuild options
-   * @returns {import("esbuild").TransformOptions} - Built ESBuild options
+   * @returns {import("esbuild").TransformOptions} Built ESBuild options
    */
   const buildEsbuildOptions = (esbuildOptions = {}) =>
     // Need deep copy objects to avoid https://github.com/terser/terser/issues/366
@@ -358,14 +361,14 @@ esbuildMinify.supportsWorkerThreads = () => false;
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function parcelCssMinify(input, sourceMap, minimizerOptions) {
   const [[filename, code]] = Object.entries(input);
   // eslint-disable-next-line jsdoc/no-restricted-syntax
   /**
    * @param {Partial<import("@parcel/css").TransformOptions<any>>=} parcelCssOptions Parcel CSS options
-   * @returns {import("@parcel/css").TransformOptions<any>} - Built Parcel CSS options
+   * @returns {import("@parcel/css").TransformOptions<any>} Built Parcel CSS options
    */
   const buildParcelCssOptions = (parcelCssOptions = {}) =>
     // Need deep copy objects to avoid https://github.com/terser/terser/issues/366
@@ -403,14 +406,14 @@ parcelCssMinify.supportsWorkerThreads = () => false;
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function lightningCssMinify(input, sourceMap, minimizerOptions) {
   const [[filename, code]] = Object.entries(input);
   // eslint-disable-next-line jsdoc/no-restricted-syntax
   /**
    * @param {Partial<import("lightningcss").TransformOptions<any>>=} lightningCssOptions Lightning CSS options
-   * @returns {import("lightningcss").TransformOptions<any>} - Built Lightning CSS options
+   * @returns {import("lightningcss").TransformOptions<any>} Built Lightning CSS options
    */
   const buildLightningCssOptions = (lightningCssOptions = {}) =>
     // Need deep copy objects to avoid https://github.com/terser/terser/issues/366
@@ -448,13 +451,13 @@ lightningCssMinify.supportsWorkerThreads = () => false;
  * @param {Input} input Input
  * @param {RawSourceMap=} sourceMap Source map
  * @param {CustomOptions=} minimizerOptions Minimizer options
- * @returns {Promise<MinimizedResult>} - Promise with minimized result
+ * @returns {Promise<MinimizedResult>} Promise with minimized result
  */
 async function swcMinify(input, sourceMap, minimizerOptions) {
   const [[filename, code]] = Object.entries(input);
   /**
    * @param {Partial<import("@swc/css").MinifyOptions>=} swcOptions SWC options
-   * @returns {import("@swc/css").MinifyOptions} - Built SWC options
+   * @returns {import("@swc/css").MinifyOptions} Built SWC options
    */
   const buildSwcOptions = (swcOptions = {}) =>
     // Need deep copy objects to avoid https://github.com/terser/terser/issues/366
@@ -500,7 +503,7 @@ swcMinify.supportsWorkerThreads = () => false;
 /**
  * @template T
  * @param {(() => unknown) | undefined} fn Function to memoize
- * @returns {() => T} - Memoized function
+ * @returns {() => T} Memoized function
  */
 function memoize(fn) {
   let cache = false;

test/helpers/compile.js

@@ -1,6 +1,6 @@
 /**
  * @param {import("webpack").Compiler} compiler Webpack compiler
- * @returns {Promise<import("webpack").Stats>} - Promise with webpack stats
+ * @returns {Promise<import("webpack").Stats>} Promise with webpack stats
  */
 export default function compile(compiler) {
   return new Promise((resolve, reject) => {

test/helpers/emitAssetInChildCompilationLoader.js

@@ -21,7 +21,7 @@ class PreCopyPlugin {
 }
 
 /**
- * @returns {string} - Loader result
+ * @returns {string} Loader result
  */
 export default function loader() {
   const callback = this.async();

test/helpers/emitAssetLoader.js

@@ -1,6 +1,6 @@
 /**
  * @param {string} content Loader content
- * @returns {string} - Processed content
+ * @returns {string} Processed content
  */
 export default function loader(content) {
   this.emitFile("style.css", "a { color: red; }");

test/helpers/emitAssetLoader2.js

@@ -1,6 +1,6 @@
 /**
  * @param {string} content Loader content
- * @returns {string} - Processed content
+ * @returns {string} Processed content
  */
 export default function loader(content) {
   this.emitFile("style-2.css", "a { color: coral; }");