refactor(runtime): reuse shared node runtime detection

Author: unadlib

packages/runtime/src/jspm-module-loader.ts

@@ -3,6 +3,7 @@ import {
   type RuntimeDiagnostic,
 } from "@renderify/ir";
 import type { RuntimeModuleLoader } from "./index";
+import { isNodeRuntime } from "./runtime-environment";
 import { RuntimeSourceModuleLoader } from "./runtime-source-module-loader";
 import { rewriteImportsAsync } from "./runtime-source-utils";
 
@@ -267,7 +268,7 @@ export class JspmModuleLoader implements RuntimeModuleLoader {
   }
 
   private shouldMaterializeRemoteModuleInNode(specifier: string): boolean {
-    return this.isNodeRuntime() && this.isUrl(specifier);
+    return isNodeRuntime() && this.isUrl(specifier);
   }
 
   private getRemoteSourceModuleLoader(): RuntimeSourceModuleLoader {
@@ -311,13 +312,4 @@ export class JspmModuleLoader implements RuntimeModuleLoader {
       "Node remote module materialization requires Buffer support",
     );
   }
-
-  private isNodeRuntime(): boolean {
-    return (
-      typeof process !== "undefined" &&
-      typeof process.versions === "object" &&
-      process.versions !== null &&
-      typeof process.versions.node === "string"
-    );
-  }
 }

packages/runtime/src/runtime-component-runtime.ts

@@ -14,6 +14,7 @@ import {
   getVmSpecifier,
   hasPreactFactory,
   hasVmScript,
+  isNodeRuntime,
   type NodeVmModule,
   nowMs,
 } from "./runtime-environment";
@@ -216,12 +217,7 @@ async function loadPreactModule(): Promise<PreactLikeModule | undefined> {
 }
 
 async function loadVmModule(): Promise<NodeVmModule | undefined> {
-  if (
-    typeof process === "undefined" ||
-    typeof process.versions !== "object" ||
-    process.versions === null ||
-    typeof process.versions.node !== "string"
-  ) {
+  if (!isNodeRuntime()) {
     return undefined;
   }
 

packages/runtime/src/runtime-environment.ts

@@ -17,6 +17,15 @@ export function isBrowserRuntime(): boolean {
   );
 }
 
+export function isNodeRuntime(): boolean {
+  return (
+    typeof process !== "undefined" &&
+    typeof process.versions === "object" &&
+    process.versions !== null &&
+    typeof process.versions.node === "string"
+  );
+}
+
 export interface NodeVmScript {
   runInNewContext(
     contextObject: Record<string, unknown>,

packages/runtime/src/runtime-source-module-loader.ts

@@ -13,7 +13,7 @@ import {
   isJsonModuleResponse,
   type RemoteModuleFetchResult,
 } from "./module-fetch";
-import { isBrowserRuntime } from "./runtime-environment";
+import { isBrowserRuntime, isNodeRuntime } from "./runtime-environment";
 import { isHttpUrl } from "./runtime-specifier";
 
 export interface RuntimeSourceModuleLoaderOptions {
@@ -582,12 +582,7 @@ export class RuntimeSourceModuleLoader {
     }
 
     this.nodeModuleResolverPromise = (async () => {
-      if (
-        typeof process === "undefined" ||
-        typeof process.versions !== "object" ||
-        process.versions === null ||
-        typeof process.versions.node !== "string"
-      ) {
+      if (!isNodeRuntime()) {
         return undefined;
       }
 
@@ -618,12 +613,7 @@ export class RuntimeSourceModuleLoader {
     }
 
     this.nodePathToFileUrlPromise = (async () => {
-      if (
-        typeof process === "undefined" ||
-        typeof process.versions !== "object" ||
-        process.versions === null ||
-        typeof process.versions.node !== "string"
-      ) {
+      if (!isNodeRuntime()) {
         return undefined;
       }
 
@@ -649,12 +639,7 @@ export class RuntimeSourceModuleLoader {
     }
 
     this.nodePathModulePromise = (async () => {
-      if (
-        typeof process === "undefined" ||
-        typeof process.versions !== "object" ||
-        process.versions === null ||
-        typeof process.versions.node !== "string"
-      ) {
+      if (!isNodeRuntime()) {
         return undefined;
       }