Eslint fix

Author: vishnuv688

packages/app/src/controller/DataManager.ts

@@ -91,7 +91,11 @@ export class DataManagerController implements ReactiveController {
     // If we are already tracking a feature-level rerun and this clear is for
     // a child scenario (not the top-level rerun trigger itself), skip resetting
     // execution data so previously-completed scenarios' data is preserved.
-    const isChildOfActiveRerun = !!(uid && rerunState.activeRerunSuiteUid && uid !== rerunState.activeRerunSuiteUid)
+    const isChildOfActiveRerun = !!(
+      uid &&
+      rerunState.activeRerunSuiteUid &&
+      uid !== rerunState.activeRerunSuiteUid
+    )
 
     if (!isChildOfActiveRerun) {
       this.#resetExecutionData()

packages/nightwatch-devtools/example/tests/login.js

@@ -1,7 +1,11 @@
 describe('The Internet Guinea Pig Website', function () {
+  afterEach(async function (browser) {
+    await browser.end()
+  })
+
   it('should log into the secure area with valid credentials', async function (browser) {
     console.log('[TEST] Navigating to login page')
-    browser
+    await browser
       .url('https://the-internet.herokuapp.com/login')
       .waitForElementVisible('body')
 
@@ -15,7 +19,7 @@ describe('The Internet Guinea Pig Website', function () {
       '[TEST] Verifying flash message: You logged into a secure area!'
     )
     await browser
-      .waitForElementVisible('#flash')
+      .waitForElementVisible('#flash', 10000)
       .assert.textContains('#flash', 'You logged into a secure area!')
 
     console.log('[TEST] Flash message verified successfully')
@@ -35,8 +39,8 @@ describe('The Internet Guinea Pig Website', function () {
 
     console.log('[TEST] Verifying flash message: Your username is invalid!')
     await browser
-      .waitForElementVisible('.flash', 5000)
-      .assert.textContains('.flash', 'Your username is invalid!')
+      .waitForElementVisible('#flash', 10000)
+      .assert.textContains('#flash', 'Your username is invalid!')
 
     console.log('[TEST] Flash message verified successfully')
   })

packages/nightwatch-devtools/src/constants.ts

@@ -93,7 +93,8 @@ export const NAVIGATION_COMMANDS = ['url', 'navigate', 'navigateTo'] as const
 export const SPINNER_RE = /^[⠋⠙⠹⠸⠼⠴⠦⠧⠇⠏]/u
 
 /** Matches a path segment that indicates a test/spec directory (e.g. /tests/, /spec/, /nightwatch/examples/, /features/). */
-export const TEST_PATH_PATTERN = /\/(test|spec|tests|nightwatch|examples?|features|step-definitions)\//i
+export const TEST_PATH_PATTERN =
+  /\/(test|spec|tests|nightwatch|examples?|features|step-definitions)\//i
 
 /** Matches file names that follow the *.test.ts / *.spec.js naming convention. */
 export const TEST_FILE_PATTERN = /\.(?:test|spec)\.[cm]?[jt]sx?$/i

packages/nightwatch-devtools/src/helpers/browserProxy.ts

@@ -96,14 +96,17 @@ export class BrowserProxy {
           result.perform((done: Function) => {
             injectAndCapture().finally(() => done && done())
           })
-        } else {
-          // Cucumber async/await: result is a Promise (or thenable).
-          Promise.resolve(result)
-            .then(injectAndCapture)
-            .catch(() => {})
+          return result
         }
-
-        return result
+        // Cucumber async/await: result is a Promise (or thenable).
+        // Return the AUGMENTED promise so that `await browser.url(...)` in
+        // the step definition waits for injectAndCapture to finish before
+        // Cucumber moves to the next step. Without this the injection races
+        // with the next step's commands (e.g. setValue), causing stale-element
+        // errors because the script-tag insertion mutates the DOM mid-form.
+        return Promise.resolve(result)
+          .then(injectAndCapture)
+          .catch(() => {})
       }
     }
 

packages/nightwatch-devtools/src/helpers/utils.ts

@@ -151,7 +151,9 @@ export function extractTestMetadata(filePath: string): TestFileMetadata {
         }
       }
       // describe/it style: it('name', ...) / test('name', ...) / specify('name', ...)
-      const itMatch = line.match(/(?:it|test|specify)\s*\(\s*['"`]([^'"`]+)['"`]/)
+      const itMatch = line.match(
+        /(?:it|test|specify)\s*\(\s*['"`]([^'"`]+)['"`]/
+      )
       if (itMatch) {
         result.testNames.push(itMatch[1])
         result.testLines.push(lineNum)

packages/nightwatch-devtools/src/index.ts

@@ -33,13 +33,7 @@ import {
   findFreePort,
   resolveNightwatchConfig
 } from './helpers/utils.js'
-import {
-  DEFAULTS,
-  TIMING,
-  TEST_STATE,
-  CONFIG_FILENAMES,
-  PLUGIN_GLOBAL_KEY
-} from './constants.js'
+import { DEFAULTS, TIMING, TEST_STATE, PLUGIN_GLOBAL_KEY } from './constants.js'
 
 const log = logger('@wdio/nightwatch-devtools')
 
@@ -607,20 +601,22 @@ class NightwatchDevToolsPlugin {
               path.join(workspaceRoot, sf, modulePath + '.js'),
               path.join(workspaceRoot, sf, modulePath + '.ts'),
               path.join(workspaceRoot, sf, modulePath + '.cjs'),
-              path.join(workspaceRoot, sf, modulePath),
+              path.join(workspaceRoot, sf, modulePath)
             ]
           : []
       )
       const possiblePaths = [
         // Highest priority: expand module path via each configured src_folder
         ...srcFolderPaths,
         // Fallback: treat module path as relative to cwd (works when src_folders isn't nested)
-        ...(modulePath ? [
-          path.join(workspaceRoot, modulePath + '.js'),
-          path.join(workspaceRoot, modulePath + '.ts'),
-          path.join(workspaceRoot, modulePath + '.cjs'),
-          path.join(workspaceRoot, modulePath),
-        ] : []),
+        ...(modulePath
+          ? [
+              path.join(workspaceRoot, modulePath + '.js'),
+              path.join(workspaceRoot, modulePath + '.ts'),
+              path.join(workspaceRoot, modulePath + '.cjs'),
+              path.join(workspaceRoot, modulePath)
+            ]
+          : []),
         path.join(workspaceRoot, 'example/tests', testFile + '.js'),
         path.join(workspaceRoot, 'example/tests', testFile),
         path.join(workspaceRoot, 'tests', testFile + '.js'),

packages/nightwatch-devtools/src/session.ts

@@ -573,12 +573,14 @@ export class SessionCapturer {
       // Poll for collector — the async IIFE may take a moment to initialise
       let hasCollector = false
       for (let attempt = 0; attempt < 5; attempt++) {
-        await browser.pause(200)
+        await new Promise((resolve) => setTimeout(resolve, 200))
         const checkResult = await browser.execute(
           'return typeof window.wdioTraceCollector !== "undefined"'
         )
         hasCollector = ((checkResult as any)?.value ?? checkResult) === true
-        if (hasCollector) break
+        if (hasCollector) {
+          break
+        }
       }
 
       if (hasCollector) {