Missing return values

[roelvermeulen]

According to the specifications, the functions beginTransaction(), commit() and rollback() need to return a value: true in case of success and false in case of failure. So to be compatible, some error checking needs to be introduced.

[wakeless]

Where is the specification? Is it return true if the commit is successful or rollback is successful?

[roelvermeulen]

Specifications:
http://php.net/manual/en/pdo.begintransaction.php
http://php.net/manual/en/pdo.commit.php
http://php.net/manual/en/pdo.rollback.php

Always return true when successful, false on failure. In your code, the original begintransaction() and the exec() function also return a value which indicates success or failure. You should pass these values on. The exec() function returns a number in case of success (=number of rows modified) or false on failure, and requires a !==false check.

For example, you could modify the beginTransaction() function like this:

public function beginTransaction() {
    $ret = false;
    if(!$this->nestable() || $this->transLevel == 0) {
      $ret = parent::beginTransaction();
    } else {
      $ret = $this->exec("SAVEPOINT LEVEL{$this->transLevel}") !== false;
    }

    $this->transLevel++;
    return $ret;
}