refactor: extract VP_BINARY_NAME const and fix review findings

- Extract VP_BINARY_NAME const to vite_setup::lib.rs, replacing 5
  inline cfg!(windows) expressions across vite_setup, vite_installer,
  and vite_global_cli
- Fix create_env_files to check exit code and log warning on failure,
  matching refresh_shims behavior
- Fix else { if let → else if let (clippy collapsible_else_if)

Author: fengmk2

crates/vite_global_cli/src/commands/upgrade/mod.rs

@@ -147,7 +147,7 @@ async fn install_platform_and_main(
     install::extract_platform_package(platform_data, version_dir).await?;
 
     // Verify binary was extracted
-    let binary_name = if cfg!(windows) { "vp.exe" } else { "vp" };
+    let binary_name = vite_setup::VP_BINARY_NAME;
     let binary_path = version_dir.join("bin").join(binary_name);
     if !tokio::fs::try_exists(&binary_path).await.unwrap_or(false) {
         return Err(Error::Upgrade(

crates/vite_installer/src/main.rs

@@ -20,9 +20,7 @@ use indicatif::{ProgressBar, ProgressStyle};
 use owo_colors::OwoColorize;
 use vite_install::request::HttpClient;
 use vite_path::AbsolutePathBuf;
-use vite_setup::{install, integrity, platform, registry};
-
-const VP_BINARY_NAME: &str = if cfg!(windows) { "vp.exe" } else { "vp" };
+use vite_setup::{VP_BINARY_NAME, install, integrity, platform, registry};
 
 /// Restrict DLL search to system32 only to prevent DLL hijacking
 /// when the installer is run from a Downloads folder.
@@ -206,10 +204,8 @@ async fn do_install(
         if let Err(e) = install::refresh_shims(install_dir).await {
             print_warn(&format!("Node.js manager setup failed (non-fatal): {e}"));
         }
-    } else {
-        if let Err(e) = install::create_env_files(install_dir).await {
-            print_warn(&format!("Env file creation failed (non-fatal): {e}"));
-        }
+    } else if let Err(e) = install::create_env_files(install_dir).await {
+        print_warn(&format!("Env file creation failed (non-fatal): {e}"));
     }
 
     if !opts.no_modify_path {

crates/vite_setup/src/install.rs

@@ -156,7 +156,7 @@ pub async fn install_production_deps(
     version_dir: &AbsolutePath,
     registry: Option<&str>,
 ) -> Result<(), Error> {
-    let vp_binary = version_dir.join("bin").join(if cfg!(windows) { "vp.exe" } else { "vp" });
+    let vp_binary = version_dir.join("bin").join(crate::VP_BINARY_NAME);
 
     if !tokio::fs::try_exists(&vp_binary).await.unwrap_or(false) {
         return Err(Error::Setup(
@@ -289,8 +289,7 @@ pub async fn swap_current_link(install_dir: &AbsolutePath, version: &str) -> Res
 
 /// Refresh shims by running `vp env setup --refresh` with the new binary.
 pub async fn refresh_shims(install_dir: &AbsolutePath) -> Result<(), Error> {
-    let vp_binary =
-        install_dir.join("current").join("bin").join(if cfg!(windows) { "vp.exe" } else { "vp" });
+    let vp_binary = install_dir.join("current").join("bin").join(crate::VP_BINARY_NAME);
 
     if !tokio::fs::try_exists(&vp_binary).await.unwrap_or(false) {
         tracing::warn!(
@@ -324,18 +323,26 @@ pub async fn refresh_shims(install_dir: &AbsolutePath) -> Result<(), Error> {
 /// Used when the Node.js manager is disabled — ensures env files exist
 /// even without a full shim refresh.
 pub async fn create_env_files(install_dir: &AbsolutePath) -> Result<(), Error> {
-    let vp_binary =
-        install_dir.join("current").join("bin").join(if cfg!(windows) { "vp.exe" } else { "vp" });
+    let vp_binary = install_dir.join("current").join("bin").join(crate::VP_BINARY_NAME);
 
     if !tokio::fs::try_exists(&vp_binary).await.unwrap_or(false) {
         return Ok(());
     }
 
-    tokio::process::Command::new(vp_binary.as_path())
+    let output = tokio::process::Command::new(vp_binary.as_path())
         .args(["env", "setup", "--env-only"])
         .output()
         .await?;
 
+    if !output.status.success() {
+        let stderr = String::from_utf8_lossy(&output.stderr);
+        tracing::warn!(
+            "env setup --env-only exited with code {}, continuing anyway\n{}",
+            output.status.code().unwrap_or(-1),
+            stderr.trim()
+        );
+    }
+
     Ok(())
 }
 

crates/vite_setup/src/lib.rs

@@ -15,3 +15,6 @@ pub mod registry;
 
 /// Maximum number of old versions to keep.
 pub const MAX_VERSIONS_KEEP: usize = 5;
+
+/// Platform-specific binary name for the `vp` CLI.
+pub const VP_BINARY_NAME: &str = if cfg!(windows) { "vp.exe" } else { "vp" };