Skip to content

Commit ce25eb6

Browse files
authored
chore!(git): Remove insecure git+git support (#379)
2 parents e4da02b + 96e4863 commit ce25eb6

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

CHANGES

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ $ pip install --user --upgrade --pre libvcs
1515

1616
### Breaking changes
1717

18+
- {issue}`379` Support for `git+git` URLs removed. Pip removed these in 21.0 due to them being
19+
insecure [^pip-git+git]
1820
- {issue}`372` Typings moved from `libvcs.types` -> {mod}`libvcs._internal.types`
1921
- {issue}`377` Remove deprecated functions and exceptions
2022

@@ -24,6 +26,8 @@ $ pip install --user --upgrade --pre libvcs
2426
- Moved `libvcs.shortcuts.create_project()` to {func}`libvcs._internal.shortcuts.create_project`
2527
- Removed {exc}`libvcs.exc.InvalidPipURL`
2628

29+
[^pip-git+git]: pip removes `git+git@` <https://github.com/pypa/pip/pull/7543>
30+
2731
### Fixes
2832

2933
- Minor spelling fix in Git's `convert_pip_url()` exception

libvcs/projects/git.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def convert_pip_url(pip_url: str) -> VCSLocation:
157157

158158
class GitProject(BaseProject):
159159
bin_name = "git"
160-
schemes = ("git", "git+http", "git+https", "git+git", "git+file")
160+
schemes = ("git", "git+http", "git+https", "git+file")
161161
_remotes: GitProjectRemoteDict
162162

163163
def __init__(

0 commit comments

Comments
 (0)