pytest_plugin(refactor[types]): Rename CreateRepoPytestFixtureFn -> CreateRepoFn

why: "PytestFixture" is redundant context inside pytest_plugin.py;
the shorter name aligns with the existing Fn-suffix convention used
by CreateRepoPostInitFn.
what:
- Rename Protocol class in src/libvcs/pytest_plugin.py
- Update all import sites and type annotations across tests and README.md

Author: tony

README.md

@@ -134,11 +134,11 @@ Writing a tool that interacts with VCS? Use our fixtures to keep your tests clea
 
 ```python
 import pathlib
-from libvcs.pytest_plugin import CreateRepoPytestFixtureFn
+from libvcs.pytest_plugin import CreateRepoFn
 from libvcs.sync.git import GitSync
 
 def test_my_git_tool(
-    create_git_remote_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_repo: CreateRepoFn,
     tmp_path: pathlib.Path
 ):
     # Spin up a real, temporary Git server

src/libvcs/pytest_plugin.py

@@ -282,7 +282,7 @@ def __call__(
         ...
 
 
-class CreateRepoPytestFixtureFn(t.Protocol):
+class CreateRepoFn(t.Protocol):
     """Typing for VCS pytest fixture callback."""
 
     def __call__(
@@ -376,7 +376,7 @@ def empty_git_repo(
 def create_git_remote_bare_repo(
     remote_repos_path: pathlib.Path,
     empty_git_bare_repo: pathlib.Path,
-) -> CreateRepoPytestFixtureFn:
+) -> CreateRepoFn:
     """Return factory to create git remote repo to for clone / push purposes."""
 
     def fn(
@@ -405,7 +405,7 @@ def fn(
 def create_git_remote_repo(
     remote_repos_path: pathlib.Path,
     empty_git_repo: pathlib.Path,
-) -> CreateRepoPytestFixtureFn:
+) -> CreateRepoFn:
     """Return factory to create git remote repo to for clone / push purposes."""
 
     def fn(
@@ -456,7 +456,7 @@ def git_remote_repo_single_commit_post_init(
 @pytest.fixture(scope="session")
 @skip_if_git_missing
 def git_remote_repo(
-    create_git_remote_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_repo: CreateRepoFn,
     gitconfig: pathlib.Path,
     git_commit_envvars: GitCommitEnvVars,
 ) -> pathlib.Path:
@@ -543,7 +543,7 @@ def empty_svn_repo(
 def create_svn_remote_repo(
     remote_repos_path: pathlib.Path,
     empty_svn_repo: pathlib.Path,
-) -> CreateRepoPytestFixtureFn:
+) -> CreateRepoFn:
     """Pre-made svn repo, bare, used as a file:// remote to checkout and commit to."""
 
     def fn(
@@ -573,7 +573,7 @@ def fn(
 @pytest.fixture(scope="session")
 @skip_if_svn_missing
 def svn_remote_repo(
-    create_svn_remote_repo: CreateRepoPytestFixtureFn,
+    create_svn_remote_repo: CreateRepoFn,
 ) -> pathlib.Path:
     """Pre-made. Local file:// based SVN server."""
     return create_svn_remote_repo()
@@ -582,7 +582,7 @@ def svn_remote_repo(
 @pytest.fixture(scope="session")
 @skip_if_svn_missing
 def svn_remote_repo_with_files(
-    create_svn_remote_repo: CreateRepoPytestFixtureFn,
+    create_svn_remote_repo: CreateRepoFn,
 ) -> pathlib.Path:
     """Pre-made. Local file:// based SVN server."""
     repo_path = create_svn_remote_repo()
@@ -649,7 +649,7 @@ def create_hg_remote_repo(
     remote_repos_path: pathlib.Path,
     empty_hg_repo: pathlib.Path,
     hgconfig: pathlib.Path,
-) -> CreateRepoPytestFixtureFn:
+) -> CreateRepoFn:
     """Pre-made hg repo, bare, used as a file:// remote to checkout and commit to."""
 
     def fn(
@@ -683,7 +683,7 @@ def fn(
 @skip_if_hg_missing
 def hg_remote_repo(
     remote_repos_path: pathlib.Path,
-    create_hg_remote_repo: CreateRepoPytestFixtureFn,
+    create_hg_remote_repo: CreateRepoFn,
     hgconfig: pathlib.Path,
 ) -> pathlib.Path:
     """Pre-made, file-based repo for push and pull."""
@@ -791,9 +791,9 @@ def add_doctest_fixtures(
     set_home: pathlib.Path,
     git_commit_envvars: GitCommitEnvVars,
     hgconfig: pathlib.Path,
-    create_git_remote_repo: CreateRepoPytestFixtureFn,
-    create_svn_remote_repo: CreateRepoPytestFixtureFn,
-    create_hg_remote_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_repo: CreateRepoFn,
+    create_svn_remote_repo: CreateRepoFn,
+    create_hg_remote_repo: CreateRepoFn,
     git_repo: pathlib.Path,
 ) -> None:
     """Harness pytest fixtures to pytest's doctest namespace."""

tests/cmd/test_git.py

@@ -12,7 +12,7 @@
 from libvcs.cmd import git
 
 if t.TYPE_CHECKING:
-    from libvcs.pytest_plugin import CreateRepoPytestFixtureFn, GitCommitEnvVars
+    from libvcs.pytest_plugin import CreateRepoFn, GitCommitEnvVars
     from libvcs.sync.git import GitSync
 
 
@@ -956,7 +956,7 @@ class RemoteAddParamFixture(t.NamedTuple):
 )
 def test_remote_manager_add_params(
     git_repo: GitSync,
-    create_git_remote_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_repo: CreateRepoFn,
     test_id: str,
     fetch: bool | None,
     track: str | None,

tests/sync/test_git.py

@@ -26,7 +26,7 @@
 if t.TYPE_CHECKING:
     from pytest_mock import MockerFixture
 
-    from libvcs.pytest_plugin import CreateRepoPytestFixtureFn
+    from libvcs.pytest_plugin import CreateRepoFn
 
 if not shutil.which("git"):
     pytestmark = pytest.mark.skip(reason="git is not available")
@@ -182,7 +182,7 @@ def test_repo_update_handle_cases(
 )
 def test_repo_update_stash_cases(
     tmp_path: pathlib.Path,
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     mocker: MockerFixture,
     has_untracked_files: bool,
     needs_stash: bool,
@@ -551,7 +551,7 @@ def test_remotes_update_repo(
     lazy_constructor_options: ProjectTestFactoryLazyKwargs,
     lazy_remote_dict: ProjectTestFactoryRemoteLazyExpected,
     lazy_remote_expected: ProjectTestFactoryRemoteLazyExpected,
-    create_git_remote_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_repo: CreateRepoFn,
 ) -> None:
     """Tests GitSync with updated remotes."""
     repo_name = "myrepo"
@@ -911,7 +911,7 @@ def test_GitRemote__from_stdout_c(fixture: str, expected_result: GitStatus) -> N
 
 
 def test_repo_git_remote_checkout(
-    create_git_remote_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     projects_path: pathlib.Path,
 ) -> None:
@@ -930,7 +930,7 @@ def test_repo_git_remote_checkout(
 
 
 def test_update_repo_success_returns_sync_result(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
 ) -> None:
     """Test that a successful update_repo() returns SyncResult with ok=True."""
@@ -957,7 +957,7 @@ def test_update_repo_success_returns_sync_result(
 
 
 def test_update_repo_fetch_failure_returns_sync_result(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
 ) -> None:
     """Test that a fetch failure in update_repo() returns SyncResult with error."""
@@ -998,7 +998,7 @@ def test_update_repo_fetch_failure_returns_sync_result(
 
 
 def test_update_repo_checkout_failure_returns_sync_result(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
 ) -> None:
     """Test that a checkout failure in update_repo() returns SyncResult with error."""
@@ -1031,7 +1031,7 @@ def test_update_repo_checkout_failure_returns_sync_result(
 
 
 def test_update_repo_rev_list_head_failure_returns_sync_result(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
 ) -> None:
     """update_repo() records rev-list HEAD failure in SyncResult."""
@@ -1065,7 +1065,7 @@ def test_update_repo_rev_list_head_failure_returns_sync_result(
 
 
 def test_update_repo_submodule_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1118,7 +1118,7 @@ def test_update_repo_submodule_failure_recorded(
 
 
 def test_update_repo_symbolic_ref_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
 ) -> None:
     """Test that symbolic_ref failure on detached HEAD is recorded in SyncResult.
@@ -1158,7 +1158,7 @@ def test_update_repo_symbolic_ref_failure_recorded(
 
 
 def test_update_repo_remote_ref_not_found_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
 ) -> None:
     """Test that GitRemoteRefNotFound is caught and recorded in SyncResult.
@@ -1200,7 +1200,7 @@ def test_update_repo_remote_ref_not_found_recorded(
 
 
 def test_update_repo_obtain_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1237,7 +1237,7 @@ def test_update_repo_obtain_failure_recorded(
 
 
 def test_update_repo_set_remotes_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1281,7 +1281,7 @@ def test_update_repo_set_remotes_failure_recorded(
 
 
 def test_update_repo_remote_name_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1324,7 +1324,7 @@ def test_update_repo_remote_name_failure_recorded(
 
 
 def test_update_repo_status_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1385,7 +1385,7 @@ def status_side_effect(**kwargs: t.Any) -> str:
 
 
 def test_update_repo_stash_save_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1451,7 +1451,7 @@ def status_side_effect(**kwargs: t.Any) -> str:
 
 
 def test_update_repo_rebase_invalid_upstream_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1519,7 +1519,7 @@ def status_side_effect(**kwargs: t.Any) -> str:
 
 
 def test_update_repo_rebase_conflict_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:
@@ -1587,7 +1587,7 @@ def status_side_effect(**kwargs: t.Any) -> str:
 
 
 def test_update_repo_stash_pop_failure_recorded(
-    create_git_remote_bare_repo: CreateRepoPytestFixtureFn,
+    create_git_remote_bare_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     mocker: MockerFixture,
 ) -> None:

tests/sync/test_hg.py

@@ -16,7 +16,7 @@
 from libvcs.sync.hg import HgSync
 
 if t.TYPE_CHECKING:
-    from libvcs.pytest_plugin import CreateRepoPytestFixtureFn
+    from libvcs.pytest_plugin import CreateRepoFn
 
 if not shutil.which("hg"):
     pytestmark = pytest.mark.skip(reason="hg is not available")
@@ -113,7 +113,7 @@ def test_vulnerability_2022_03_12_command_injection(
 
 def test_update_repo_pull_failure_returns_sync_result(
     projects_path: pathlib.Path,
-    create_hg_remote_repo: CreateRepoPytestFixtureFn,
+    create_hg_remote_repo: CreateRepoFn,
 ) -> None:
     """Test that a deleted remote in update_repo() returns SyncResult with error."""
     repo_name = "my_hg_error_project"

tests/sync/test_svn.py

@@ -14,7 +14,7 @@
 if t.TYPE_CHECKING:
     import pathlib
 
-    from libvcs.pytest_plugin import CreateRepoPytestFixtureFn
+    from libvcs.pytest_plugin import CreateRepoFn
 
 if not shutil.which("svn"):
     pytestmark = pytest.mark.skip(reason="svn is not available")
@@ -60,7 +60,7 @@ def test_svn_sync_with_files(
 
 
 def test_repo_svn_remote_checkout(
-    create_svn_remote_repo: CreateRepoPytestFixtureFn,
+    create_svn_remote_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     projects_path: pathlib.Path,
 ) -> None:
@@ -79,7 +79,7 @@ def test_repo_svn_remote_checkout(
 
 
 def test_update_repo_checkout_failure_returns_sync_result(
-    create_svn_remote_repo: CreateRepoPytestFixtureFn,
+    create_svn_remote_repo: CreateRepoFn,
     tmp_path: pathlib.Path,
     projects_path: pathlib.Path,
 ) -> None: