Use ValueTask for CreateRequestUrl in http loader

Author: usercode

src/ImageWizard.Core/Caches/Key/ICacheKey.cs

@@ -12,7 +12,5 @@ public interface ICacheKey
     /// <summary>
     /// Create
     /// </summary>
-    /// <param name="input"></param>
-    /// <returns></returns>
     string Create(string input);
 }

src/ImageWizard.Core/Loaders/Gravatars/GravatarLoader.cs

@@ -21,8 +21,8 @@ public GravatarLoader(
     {
     }
 
-    protected override Task<Uri?> CreateRequestUrl(string source)
+    protected override ValueTask<Uri?> CreateRequestUrl(string source)
     {
-        return Task.FromResult<Uri?>(new Uri($"https://www.gravatar.com/avatar/{source}?size=512"));
+        return ValueTask.FromResult<Uri?>(new Uri($"https://www.gravatar.com/avatar/{source}?size=512"));
     }
 }

src/ImageWizard.Core/Loaders/Http/HttpLoader.cs

@@ -38,7 +38,7 @@ public HttpLoader(
     /// </summary>
     private IHttpContextAccessor HttpContextAccessor { get; }
 
-    protected override Task<Uri?> CreateRequestUrl(string source)
+    protected override ValueTask<Uri?> CreateRequestUrl(string source)
     {
         Uri sourceUri;
 
@@ -74,6 +74,6 @@ public HttpLoader(
             }
         }
 
-        return Task.FromResult<Uri?>(sourceUri);
+        return ValueTask.FromResult<Uri?>(sourceUri);
     }   
 }

src/ImageWizard.Core/Loaders/Http/HttpLoaderBase.cs

@@ -44,8 +44,7 @@ public HttpLoaderBase(
     /// <summary>
     /// CreateRequestUrl
     /// </summary>
-    /// <returns></returns>
-    protected abstract Task<Uri?> CreateRequestUrl(string source);
+    protected abstract ValueTask<Uri?> CreateRequestUrl(string source);
 
     /// <summary>
     /// GetAsync

src/ImageWizard.Core/Loaders/Youtube/YoutubeLoader.cs

@@ -21,16 +21,16 @@ public YouTubeLoader(
     {
     }
 
-    protected override Task<Uri?> CreateRequestUrl(string source)
+    protected override ValueTask<Uri?> CreateRequestUrl(string source)
     {
-        return Task.FromResult<Uri?>(new Uri(source));
+        return ValueTask.FromResult<Uri?>(new Uri(source));
     }
 
     public override async Task<LoaderResult> GetAsync(string source, ICachedData? existingCachedData)
     {
         string[] quality = [
                             "maxresdefault.jpg", //1920 x 1080   
-                            "hq720.jpg", //1280  x 720 
+                            "hq720.jpg",        //1280 x 720 
                             "sddefault.jpg", //640 x 480 
                             "hqdefault.jpg", //480 x 360                            
                         ];

src/ImageWizard.OpenGraph/Loaders/OpenGraphLoader.cs

@@ -22,7 +22,7 @@ public OpenGraphLoader(
     {
     }
 
-    protected override async Task<Uri?> CreateRequestUrl(string source)
+    protected override async ValueTask<Uri?> CreateRequestUrl(string source)
     {
         HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, source);
         request.SetUserAgentHeader();

src/ImageWizard.OpenStreetMap/Loaders/OpenStreetMapLoader.cs

@@ -19,8 +19,8 @@ public OpenStreetMapLoader(
     {
     }
 
-    protected override Task<Uri?> CreateRequestUrl(string source)
+    protected override ValueTask<Uri?> CreateRequestUrl(string source)
     {
-        return Task.FromResult<Uri?>(new Uri($"{Options.Value.Path.TrimEnd('/')}/{source}.png"));
+        return ValueTask.FromResult<Uri?>(new Uri($"{Options.Value.Path.TrimEnd('/')}/{source}.png"));
     }
 }