IsPartialDefinition

Author: ufcpp

samples/StringLiteralCodeAnalysisSample/StringLiteralCodeAnalysisSample.csproj

@@ -1,12 +1,12 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net5.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.9.0" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.10.0" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>

src/StringLiteralGenerator/StringLiteralGenerator.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
@@ -19,7 +19,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.9.0" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.10.0" PrivateAssets="all" />
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" />
   </ItemGroup>
 

src/StringLiteralGenerator/Utf8StringLiteralGenerator.Parser.cs

@@ -7,17 +7,8 @@ public partial class Utf8StringLiteralGenerator : ISourceGenerator
 {
     private const string attributeName = "StringLiteral.Utf8Attribute";
 
-    private static bool IsStaticPartial(MemberDeclarationSyntax m)
-    {
-        bool isStatic = false;
-        bool isPartial = false;
-        foreach (var mod in m.Modifiers)
-        {
-            isStatic |= mod.Text == "static";
-            isPartial |= mod.Text == "partial";
-        }
-        return isStatic && isPartial;
-    }
+    private static bool IsSyntaxTargetForGeneration(SyntaxNode node) =>
+        node is MethodDeclarationSyntax { AttributeLists.Count: > 0 };
 
     static bool ReturnsString(IMethodSymbol methodSymbol)
     {

src/StringLiteralGenerator/Utf8StringLiteralGenerator.cs

@@ -33,16 +33,14 @@ public void Execute(GeneratorExecutionContext context)
         {
             foreach (var m in receiver.CandidateMethods)
             {
-                if (!IsStaticPartial(m)) continue;
-
                 var model = compilation.GetSemanticModel(m.SyntaxTree);
 
                 if (m.ParameterList.Parameters.Count != 0) continue;
                 if (model.GetDeclaredSymbol(m) is not { } methodSymbol) continue;
+                if (!methodSymbol.IsPartialDefinition || !methodSymbol.IsStatic) continue;
                 if (!ReturnsString(methodSymbol)) continue;
                 if (GetUtf8Attribute(methodSymbol) is not { } value) continue;
 
-
                 yield return (new(methodSymbol.ContainingType), new(methodSymbol, value));
             }
         }
@@ -61,10 +59,9 @@ class SyntaxReceiver : ISyntaxReceiver
         public void OnVisitSyntaxNode(SyntaxNode syntaxNode)
         {
             // any field with at least one attribute is a candidate for property generation
-            if (syntaxNode is MethodDeclarationSyntax methodDeclarationSyntax
-                && methodDeclarationSyntax.AttributeLists.Count > 0)
+            if (IsSyntaxTargetForGeneration(syntaxNode))
             {
-                CandidateMethods.Add(methodDeclarationSyntax);
+                CandidateMethods.Add((MethodDeclarationSyntax)syntaxNode);
             }
         }
     }