Merge pull request #29 from OrionReed/master

Throw error if search parameters are not all strings

Author: kishorenc

typesense/documents.py

@@ -4,6 +4,8 @@
 
 from .document import Document
 from .logger import logger
+from .validation import validate_search
+from .preprocess import stringify_search_params
 from collections.abc import Iterable
 
 class Documents(object):
@@ -94,7 +96,9 @@ def export(self, params=None):
         return api_response
 
     def search(self, search_parameters):
-        return self.api_call.get(self._endpoint_path('search'), search_parameters)
+        stringified_search_params = stringify_search_params(search_parameters)
+        validate_search(stringified_search_params)
+        return self.api_call.get(self._endpoint_path('search'), stringified_search_params)
 
     def delete(self, params=None):
-      return self.api_call.delete(self._endpoint_path(), params)
+        return self.api_call.delete(self._endpoint_path(), params)

typesense/exceptions.py

@@ -45,3 +45,7 @@ class ServiceUnavailable(TypesenseClientError):
 
 class HTTPStatus0Error(TypesenseClientError):
     pass
+
+
+class InvalidParameter(TypesenseClientError):
+    pass

typesense/preprocess.py

@@ -0,0 +1,8 @@
+def stringify_search_params(params):
+    return {key:stringify(val) for key, val in params.items()}
+
+def stringify(val):
+    if isinstance(val, bool) or isinstance(val, int):
+        return str(val).lower()
+    else:
+        return val

typesense/validation.py

@@ -0,0 +1,7 @@
+from typesense.exceptions import InvalidParameter
+
+
+def validate_search(params):
+    for key in params:
+        if not isinstance(params[key], str):
+            raise InvalidParameter(f"'{key}' field expected a string but was given {type(params[key]).__name__}")