Skip to content

Commit b91afec

Browse files
fix: take a dockerfile input alongside context in app-build/app-release
A generated project's context alone can no longer name the Dockerfile too: an all-typescript project builds from the workspace root, where the Dockerfile that root context needs lives at apps/<role>/Dockerfile, not context/Dockerfile. Same shape as immich's own docker.yml call site (context: ., dockerfile: server/Dockerfile). scaffold's build.yml and release.yml call sites now pass both. Claude-Session: https://claude.ai/code/session_01J4HB8qJjdZwaAv42k6HMpv
1 parent fdb27bf commit b91afec

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

‎.github/workflows/app-build.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ on:
99
context:
1010
type: string
1111
required: true
12+
dockerfile:
13+
description: path to the Dockerfile, relative to the checkout root
14+
type: string
15+
required: true
1216

1317
permissions: {}
1418

@@ -38,6 +42,7 @@ jobs:
3842
- uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a # v7.3.0
3943
with:
4044
context: ${{ inputs.context }}
45+
file: ${{ inputs.dockerfile }}
4146
push: true
4247
tags: ${{ steps.meta.outputs.tags }}
4348
cache-from: type=gha

‎.github/workflows/app-release.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ on:
88
context:
99
type: string
1010
required: true
11+
dockerfile:
12+
description: path to the Dockerfile, relative to the checkout root
13+
type: string
14+
required: true
1115
secrets:
1216
RELEASE_APP_ID:
1317
required: false
@@ -87,6 +91,7 @@ jobs:
8791
- uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a # v7.3.0
8892
with:
8993
context: ${{ inputs.context }}
94+
file: ${{ inputs.dockerfile }}
9095
push: true
9196
tags: ${{ steps.meta.outputs.tags }}
9297
cache-from: type=gha

0 commit comments

Comments
 (0)