refactor(db): recover the previous exception handling strategy

  1. delete the exception throwing

Author: halibobo1205

chainbase/src/main/java/org/tron/common/storage/leveldb/LevelDbDataSourceImpl.java

@@ -128,7 +128,7 @@ public void initDB() {
   private void openDatabase(Options dbOptions) throws IOException {
     final Path dbPath = getDbPath();
     if (dbPath == null || dbPath.getParent() == null) {
-      throw new IOException(String.format("db path is illegal, %s/%s", parentPath, dataBaseName));
+      return;
     }
     if (!Files.isSymbolicLink(dbPath.getParent())) {
       Files.createDirectories(dbPath.getParent());

chainbase/src/main/java/org/tron/common/utils/ForkController.java

@@ -167,7 +167,7 @@ public synchronized void update(BlockCapsule blockCapsule) {
     stats[slot] = VERSION_UPGRADE;
     manager.getDynamicPropertiesStore().statsByVersion(version, stats);
     logger.info(
-        "******* Update hard fork: {}, witness size: {}, solt: {}, witness: {}, version: {}.",
+        "Update hard fork: {}, witness size: {}, solt: {}, witness: {}, version: {}.",
         Streams.zip(witnesses.stream(), Stream.of(ArrayUtils.toObject(stats)), Maps::immutableEntry)
             .map(e -> Maps
                 .immutableEntry(encode58Check(e.getKey().toByteArray()), e.getValue()))

chainbase/src/main/java/org/tron/core/db/BlockStore.java

@@ -53,7 +53,8 @@ private List<BlockCapsule> pack(Set<byte[]> values) {
       try {
         blocks.add(new BlockCapsule(bytes));
       } catch (BadItemException e) {
-        throw new TronDBException(e);
+        logger.error("Find bad item: {}", e.getMessage());
+        // throw new TronDBException(e);
       }
     }
     blocks.sort(Comparator.comparing(BlockCapsule::getNum));

chainbase/src/main/java/org/tron/core/db/accountstate/AccountStateEntity.java

@@ -1,5 +1,6 @@
 package org.tron.core.db.accountstate;
 
+import com.google.protobuf.InvalidProtocolBufferException;
 import lombok.extern.slf4j.Slf4j;
 import org.tron.common.utils.StringUtil;
 import org.tron.protos.Protocol.Account;
@@ -24,8 +25,8 @@ public AccountStateEntity(Account account) {
   public static AccountStateEntity parse(byte[] data) {
     try {
       return new AccountStateEntity().setAccount(Account.parseFrom(data));
-    } catch (Exception e) {
-      logger.error("Parse to AccountStateEntity error!", e);
+    } catch (InvalidProtocolBufferException e) {
+      logger.error("Parse to AccountStateEntity error! reason: {}", e.getMessage());
     }
     return null;
   }

chainbase/src/main/java/org/tron/core/db/common/iterator/RockStoreIterator.java

@@ -36,7 +36,12 @@ public boolean hasNext() {
         dbIterator.close();
       }
     } catch (Exception e) {
-      throw new TronDBException(e);
+      logger.error(e.getMessage(), e);
+      try {
+        dbIterator.close();
+      } catch (Exception e1) {
+        logger.error(e.getMessage(), e);
+      }
     }
     return hasNext;
   }

chainbase/src/main/java/org/tron/core/db/common/iterator/StoreIterator.java

@@ -35,7 +35,7 @@ public boolean hasNext() {
         dbIterator.close();
       }
     } catch (Exception e) {
-      throw new TronDBException(e);
+      logger.error(e.getMessage(), e);
     }
 
     return hasNext;

chainbase/src/main/java/org/tron/core/db2/core/SnapshotManager.java

@@ -473,7 +473,7 @@ public void destroy() {
           snapshotManager.revoke();
         }
       } catch (Exception e) {
-        throw new RevokingStoreIllegalStateException(e);
+        logger.error("Revoke database error.", e);
       }
       if (disableOnExit) {
         snapshotManager.disable();
@@ -482,7 +482,17 @@ public void destroy() {
 
     @Override
     public void close() {
-     destroy();
+      try {
+        if (applySnapshot) {
+          snapshotManager.revoke();
+        }
+      } catch (Exception e) {
+        logger.error("Revoke database error.", e);
+        throw new RevokingStoreIllegalStateException(e);
+      }
+      if (disableOnExit) {
+        snapshotManager.disable();
+      }
     }
   }
 

framework/src/main/java/org/tron/core/db/accountstate/AccountStateEntity.java

@@ -1,5 +1,6 @@
 package org.tron.core.db.accountstate;
 
+import com.google.protobuf.InvalidProtocolBufferException;
 import lombok.extern.slf4j.Slf4j;
 import org.tron.common.utils.StringUtil;
 import org.tron.protos.Protocol.Account;
@@ -23,8 +24,8 @@ public AccountStateEntity(Account account) {
   public static AccountStateEntity parse(byte[] data) {
     try {
       return new AccountStateEntity().setAccount(Account.parseFrom(data));
-    } catch (Exception e) {
-      logger.error("Parse to AccountStateEntity error!", e);
+    } catch (InvalidProtocolBufferException e) {
+      logger.error("Parse to AccountStateEntity error! reason: {}", e.getMessage());
     }
     return null;
   }